Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 539843002: find_sdk.py: pylint clean (Closed)

Created:
6 years, 3 months ago by ukai
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@enable_flash
Project:
chromium
Visibility:
Public.

Description

find_sdk.py: pylint clean W0105: 16,-1: String statement has no effect C0323: 45,4:main: Operator not followed by a space print >>sys.stderr, out ^ BUG= Committed: https://crrev.com/9520d408282a2a498ef6fc20f9abacfb899abbe7 Cr-Commit-Position: refs/heads/master@{#293294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M build/mac/find_sdk.py View 4 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ukai
6 years, 3 months ago (2014-09-04 04:46:00 UTC) #2
Nico
lgtm
6 years, 3 months ago (2014-09-04 05:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ukai@chromium.org/539843002/1
6 years, 3 months ago (2014-09-04 05:28:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 63cc413b9b478d841f4ee18c480d5556eb4fd03a
6 years, 3 months ago (2014-09-04 13:58:08 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9520d408282a2a498ef6fc20f9abacfb899abbe7
Cr-Commit-Position: refs/heads/master@{#293294}

Powered by Google App Engine
This is Rietveld 408576698