Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: Source/core/rendering/svg/RenderSVGResourceMarker.cpp

Issue 539833004: [SVG2] Add support for marker orient="auto-start-reverse". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceMarker.h ('k') | Source/core/rendering/svg/RenderSVGShape.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/RenderSVGResourceMarker.cpp
diff --git a/Source/core/rendering/svg/RenderSVGResourceMarker.cpp b/Source/core/rendering/svg/RenderSVGResourceMarker.cpp
index d338016966fc9792ba3772d459d14c450716b86d..b2700df79a645e0f6d85308f3be76f5c08badb97 100644
--- a/Source/core/rendering/svg/RenderSVGResourceMarker.cpp
+++ b/Source/core/rendering/svg/RenderSVGResourceMarker.cpp
@@ -115,17 +115,21 @@ float RenderSVGResourceMarker::angle() const
return angle;
}
-AffineTransform RenderSVGResourceMarker::markerTransformation(const FloatPoint& origin, float autoAngle, float strokeWidth) const
+AffineTransform RenderSVGResourceMarker::markerTransformation(const FloatPoint& origin, float autoAngle, float strokeWidth, bool isStartMarker) const
{
SVGMarkerElement* marker = toSVGMarkerElement(element());
ASSERT(marker);
float markerAngle = angle();
bool useStrokeWidth = marker->markerUnits()->currentValue()->enumValue() == SVGMarkerUnitsStrokeWidth;
-
+ if (markerAngle == -1) {
+ markerAngle = autoAngle;
+ if (isStartMarker && marker->orientType()->currentValue()->enumValue() == SVGMarkerOrientAutoStartReverse)
+ markerAngle += 180;
fs 2014/09/09 12:18:21 I'm curious if this (adjustment) would be nicer in
+ }
AffineTransform transform;
transform.translate(origin.x(), origin.y());
- transform.rotate(markerAngle == -1 ? autoAngle : markerAngle);
+ transform.rotate(markerAngle);
transform = markerContentTransformation(transform, referencePoint(), useStrokeWidth ? strokeWidth : -1);
return transform;
}
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceMarker.h ('k') | Source/core/rendering/svg/RenderSVGShape.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698