Source/core/rendering/svg/RenderSVGShape.cpp - Issue 539833004: [SVG2] Add support for marker orient="auto-start-reverse".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGShape.cpp

Issue 539833004: [SVG2] Add support for marker orient="auto-start-reverse". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/svg/markers/marker-orientation-02-expected.svg ('K') | « Source/core/rendering/svg/RenderSVGResourceMarker.cpp ('k') | Source/core/svg/SVGAngle.h » ('j') | Source/core/svg/SVGAngle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGShape.cpp

diff --git a/Source/core/rendering/svg/RenderSVGShape.cpp b/Source/core/rendering/svg/RenderSVGShape.cpp

index 559a9511a0037baf82046976eed77ac2f3e7a920..fbd4ad0d282f70212ce9323a4e408da962b28b64 100644

--- a/Source/core/rendering/svg/RenderSVGShape.cpp

+++ b/Source/core/rendering/svg/RenderSVGShape.cpp

@@ -361,7 +361,7 @@ FloatRect RenderSVGShape::markerRect(float strokeWidth) const

unsigned size = m_markerPositions.size();

for (unsigned i = 0; i < size; ++i) {

if (RenderSVGResourceMarker* marker = markerForType(m_markerPositions[i].type, markerStart, markerMid, markerEnd))

- boundaries.unite(marker->markerBoundaries(marker->markerTransformation(m_markerPositions[i].origin, m_markerPositions[i].angle, strokeWidth)));

+ boundaries.unite(marker->markerBoundaries(marker->markerTransformation(m_markerPositions[i].origin, m_markerPositions[i].angle, strokeWidth, m_markerPositions[i].type == StartMarker)));

}

return boundaries;

}

@@ -439,7 +439,7 @@ void RenderSVGShape::drawMarkers(PaintInfo& paintInfo)

unsigned size = m_markerPositions.size();

for (unsigned i = 0; i < size; ++i) {

if (RenderSVGResourceMarker* marker = markerForType(m_markerPositions[i].type, markerStart, markerMid, markerEnd))

- marker->draw(paintInfo, marker->markerTransformation(m_markerPositions[i].origin, m_markerPositions[i].angle, strokeWidth));

+ marker->draw(paintInfo, marker->markerTransformation(m_markerPositions[i].origin, m_markerPositions[i].angle, strokeWidth, m_markerPositions[i].type == StartMarker));

}