Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 539833003: [turbofan] Value numbering should never replace a node with itself. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Value numbering should never replace a node with itself. R=mstarzinger@chromium.org TEST=compiler-unittests Committed: https://code.google.com/p/v8/source/detail?r=23724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/value-numbering-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/value-numbering-reducer-unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-05 10:39:47 UTC) #1
Michael Starzinger
LGTM.
6 years, 3 months ago (2014-09-05 10:40:55 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-05 10:41:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23724 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698