Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3389)

Unified Diff: chrome/browser/chromeos/login/screens/controller_pairing_screen.h

Issue 539733002: Move ownership of the ControllerPairingController into the WizardController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/controller_pairing_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/screens/controller_pairing_screen.h
diff --git a/chrome/browser/chromeos/login/screens/controller_pairing_screen.h b/chrome/browser/chromeos/login/screens/controller_pairing_screen.h
index c280e4b8e976e8ccd83b9ba1243e43fb1b48e53c..cd66be696e813118fe7b41a52e3a1704f1343194 100644
--- a/chrome/browser/chromeos/login/screens/controller_pairing_screen.h
+++ b/chrome/browser/chromeos/login/screens/controller_pairing_screen.h
@@ -19,8 +19,10 @@ class ControllerPairingScreen :
public pairing_chromeos::ControllerPairingController::Observer,
public ControllerPairingScreenActor::Delegate {
public:
- ControllerPairingScreen(ScreenObserver* observer,
- ControllerPairingScreenActor* actor);
+ ControllerPairingScreen(
+ ScreenObserver* observer,
+ ControllerPairingScreenActor* actor,
+ pairing_chromeos::ControllerPairingController* controller);
virtual ~ControllerPairingScreen();
private:
@@ -51,9 +53,8 @@ class ControllerPairingScreen :
ControllerPairingScreenActor* actor_;
- // Controller performing pairing. Owned by the screen for now.
- // TODO(dzhioev): move to proper place later.
- scoped_ptr<pairing_chromeos::ControllerPairingController> controller_;
+ // Controller performing pairing. Owned by the wizard controller.
+ pairing_chromeos::ControllerPairingController* controller_;
achuithb 2014/09/03 22:26:07 Should this be a weak reference?
Zachary Kuznia 2014/09/04 04:21:48 No, for same reason that |actor_| is not a weak po
// Current stage of pairing process.
Stage current_stage_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/controller_pairing_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698