Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 539733002: Move ownership of the ControllerPairingController into the WizardController. (Closed)

Created:
6 years, 3 months ago by Zachary Kuznia
Modified:
6 years, 3 months ago
Reviewers:
achuithb, zel
CC:
achuithb, dzhioev (left Google)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ownership of the ControllerPairingController into the WizardController. BUG=None R=achuith@chromium.org, zelidrag@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c60975f9cc0a4a40bd8365cf7d322926c12b2361

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M chrome/browser/chromeos/login/screens/controller_pairing_screen.h View 2 chunks +6 lines, -5 lines 2 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
Zachary Kuznia
Please take a look
6 years, 3 months ago (2014-09-03 22:00:10 UTC) #2
zel
lgtm
6 years, 3 months ago (2014-09-03 22:24:28 UTC) #3
achuithb
https://codereview.chromium.org/539733002/diff/1/chrome/browser/chromeos/login/screens/controller_pairing_screen.h File chrome/browser/chromeos/login/screens/controller_pairing_screen.h (right): https://codereview.chromium.org/539733002/diff/1/chrome/browser/chromeos/login/screens/controller_pairing_screen.h#newcode57 chrome/browser/chromeos/login/screens/controller_pairing_screen.h:57: pairing_chromeos::ControllerPairingController* controller_; Should this be a weak reference?
6 years, 3 months ago (2014-09-03 22:26:07 UTC) #5
Zachary Kuznia
https://codereview.chromium.org/539733002/diff/1/chrome/browser/chromeos/login/screens/controller_pairing_screen.h File chrome/browser/chromeos/login/screens/controller_pairing_screen.h (right): https://codereview.chromium.org/539733002/diff/1/chrome/browser/chromeos/login/screens/controller_pairing_screen.h#newcode57 chrome/browser/chromeos/login/screens/controller_pairing_screen.h:57: pairing_chromeos::ControllerPairingController* controller_; On 2014/09/03 22:26:07, achuithb wrote: > Should ...
6 years, 3 months ago (2014-09-04 04:21:49 UTC) #6
achuithb
lgtm
6 years, 3 months ago (2014-09-04 09:01:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/539733002/1
6 years, 3 months ago (2014-09-04 16:16:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53571)
6 years, 3 months ago (2014-09-04 18:43:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/539733002/1
6 years, 3 months ago (2014-09-04 18:50:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47854)
6 years, 3 months ago (2014-09-04 20:52:13 UTC) #15
Zachary Kuznia
Committed patchset #1 (id:1) manually as c60975f (presubmit successful).
6 years, 3 months ago (2014-09-04 21:30:13 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:42 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c60975f9cc0a4a40bd8365cf7d322926c12b2361
Cr-Commit-Position: refs/heads/master@{#293337}

Powered by Google App Engine
This is Rietveld 408576698