Deprecate 'singleton' option in chrome.apps.window.create().

Deprecate 'singleton' option in chrome.apps.window.create().

This keeps the feature as-is but shows a warning in the developer
console so the developers can fix their code before removing the
feature breaks it.

BUG=313986
TEST=When opening a new window with chrome.apps.window.create() if the
options parameter contain a 'singleton' option set to false and a 'id',
the developer console should show a warning.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233176

[benwells, 2013-11-04 01:54:01]

Cool, thanks for jumping on this so quickly :)

https://codereview.chromium.org/53973003/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/app_window/app_window_api.cc (right):

https://codereview.chromium.org/53973003/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/app_window/app_window_api.cc:165: "'singleton'
option in chrome.apps.window.create() is deprecated! "
Nit: start the sentence with 'The'. Also change 'fix' to 'change'.

https://codereview.chromium.org/53973003/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/app_window.idl (right):

https://codereview.chromium.org/53973003/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/app_window.idl:105: // (Deprecated; multiple
windows with the same id is no longer supported.)
Update doco for ID to mention that if a window with the same ID is already open,
it will be focused instead of shown.

[mlamouri (slow - plz ping), 2013-11-04 05:39:49]

New patch ready for review.

[benwells, 2013-11-04 05:43:49]

lgtm

[commit-bot: I haz the power, 2013-11-04 05:56:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/53973003/70001

[commit-bot: I haz the power, 2013-11-04 08:37:38]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-11-04 09:49:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/53973003/70001

[commit-bot: I haz the power, 2013-11-04 11:47:50]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-11-04 23:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/53973003/70001

[commit-bot: I haz the power, 2013-11-05 03:11:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/53973003/70001

[commit-bot: I haz the power, 2013-11-05 06:54:51]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 07:05:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/53973003/70001

[commit-bot: I haz the power, 2013-11-05 08:24:57]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-06 00:11:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/53973003/70001

[commit-bot: I haz the power, 2013-11-06 01:23:35]

Change committed as 233176