Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 539693002: Remove use of EXPERIMENTAL_getActiveOps from layer hoisting code (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove use of EXPERIMENTAL_getActiveOps from layer hoisting code This is getting in the way of switching to the SkRecord backend and is of questionable value. Committed: https://skia.googlesource.com/skia/+/2ed8a75c284fd8e74912de67691acf97bfb7a7b7

Patch Set 1 #

Patch Set 2 : Fix comment & move init into loop #

Total comments: 1

Patch Set 3 : Remove the SkPicture entry point entirely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -86 lines) Patch
M include/core/SkPicture.h View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M src/core/SkPicture.cpp View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 2 chunks +24 lines, -63 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
https://codereview.chromium.org/539693002/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/539693002/diff/20001/src/gpu/SkGpuDevice.cpp#newcode1938 src/gpu/SkGpuDevice.cpp:1938: // Render the entire picture using new layers This ...
6 years, 3 months ago (2014-09-03 20:22:06 UTC) #2
bsalomon
lgtm
6 years, 3 months ago (2014-09-03 20:31:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/539693002/40001
6 years, 3 months ago (2014-09-03 20:38:00 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 20:46:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 2ed8a75c284fd8e74912de67691acf97bfb7a7b7

Powered by Google App Engine
This is Rietveld 408576698