Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 539653002: [blink] Remove XMLViewer.js/css post blink-in-js migration of XML tree viewer. (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[blink] Remove XMLViewer.js/css post blink-in-js migration of XML tree viewer. CL, https://codereview.chromium.org/479753003, migrated the usage of XML tree viewer to be implemented in blink-in-js. Post the migration, the files XMLViewer.js/css are no longer used by any native code directly and hence should be removed. TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -510 lines) Patch
D Source/core/xml/XMLViewer.css View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/xml/XMLViewer.js View 1 chunk +0 lines, -432 lines 0 comments Download
M public/blink_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-03 19:03:54 UTC) #3
vivekg
6 years, 3 months ago (2014-09-04 08:02:26 UTC) #5
haraken
LGTM
6 years, 3 months ago (2014-09-04 08:05:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/539653002/1
6 years, 3 months ago (2014-09-04 08:09:34 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-04 08:41:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/539653002/1
6 years, 3 months ago (2014-09-04 15:29:26 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23452)
6 years, 3 months ago (2014-09-04 16:32:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/539653002/1
6 years, 3 months ago (2014-09-04 16:36:24 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 17:05:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181380

Powered by Google App Engine
This is Rietveld 408576698