Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 539603002: adoptNode wasn't clearing the accessibility cache. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
esprehn
CC:
aboxhall, blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, dmazzoni, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

adoptNode wasn't clearing the accessibility cache. I don't believe this was a recent regression, it's possible that recent changes simply made it easier to trigger this crash. BUG=409506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181443

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add doctype, get rid of <html>, <head>, <body> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
A LayoutTests/accessibility/adopt-node-causes-crash.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/adopt-node-causes-crash-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/dom/TreeScopeAdopter.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dmazzoni
6 years, 3 months ago (2014-09-03 17:58:12 UTC) #2
esprehn
lgtm https://codereview.chromium.org/539603002/diff/1/LayoutTests/accessibility/adopt-node-causes-crash.html File LayoutTests/accessibility/adopt-node-causes-crash.html (right): https://codereview.chromium.org/539603002/diff/1/LayoutTests/accessibility/adopt-node-causes-crash.html#newcode1 LayoutTests/accessibility/adopt-node-causes-crash.html:1: <html> Add <!DOCTYPE html>, remove <head>, Body> and ...
6 years, 3 months ago (2014-09-04 20:00:46 UTC) #3
dmazzoni
https://codereview.chromium.org/539603002/diff/1/LayoutTests/accessibility/adopt-node-causes-crash.html File LayoutTests/accessibility/adopt-node-causes-crash.html (right): https://codereview.chromium.org/539603002/diff/1/LayoutTests/accessibility/adopt-node-causes-crash.html#newcode1 LayoutTests/accessibility/adopt-node-causes-crash.html:1: <html> On 2014/09/04 20:00:46, esprehn wrote: > Add <!DOCTYPE ...
6 years, 3 months ago (2014-09-05 00:19:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/539603002/20001
6 years, 3 months ago (2014-09-05 05:14:10 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 06:15:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181443

Powered by Google App Engine
This is Rietveld 408576698