Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 539553002: Removed dependency on pytz (Closed)

Created:
6 years, 3 months ago by Sergiy Byelozyorov
Modified:
6 years, 3 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/testing_support@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M testing_support/git/repo.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sergiy Byelozyorov
6 years, 3 months ago (2014-09-03 16:16:50 UTC) #1
agable
LGTM, but please use proper indentation. https://codereview.chromium.org/539553002/diff/1/testing_support/git/repo.py File testing_support/git/repo.py (right): https://codereview.chromium.org/539553002/diff/1/testing_support/git/repo.py#newcode71 testing_support/git/repo.py:71: def utcoffset(self, dt): ...
6 years, 3 months ago (2014-09-03 16:20:41 UTC) #3
agable
Also, please include BUG= line.
6 years, 3 months ago (2014-09-03 16:21:20 UTC) #4
Sergiy Byelozyorov
https://codereview.chromium.org/539553002/diff/1/testing_support/git/repo.py File testing_support/git/repo.py (right): https://codereview.chromium.org/539553002/diff/1/testing_support/git/repo.py#newcode71 testing_support/git/repo.py:71: def utcoffset(self, dt): return datetime.timedelta(0) On 2014/09/03 16:20:41, agable ...
6 years, 3 months ago (2014-09-03 16:22:33 UTC) #5
Sergiy Byelozyorov
Committed patchset #2 (id:20001) manually as 86d39fc (presubmit successful).
6 years, 3 months ago (2014-09-03 16:22:57 UTC) #8
iannucci
6 years, 3 months ago (2014-09-03 16:26:41 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698