Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 539543002: Fix two bugs in the extension actions toolbar (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Finnur, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix two bugs in the extension actions toolbar 1. Previously, we didn't animate the browser actions container when the visible count changed, because we set the width prior to calling animate. Fix it by animating to the desired width. 2. There was a bug where we would improperly hide an extension upon loading another, because we wouldn't account for the chevron width. Fix this, and add a test. BUG=410348 BUG=410361 Committed: https://crrev.com/b1a2fc8cfeb5a38360b622f030f1e756df475cfe Cr-Commit-Position: refs/heads/master@{#293947}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -25 lines) Patch
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 6 chunks +37 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Devlin
6 years, 3 months ago (2014-09-03 18:58:42 UTC) #4
Finnur
Sorry, this slipped through the cracks. Only noticed it now. LGTM.
6 years, 3 months ago (2014-09-05 10:22:12 UTC) #5
Devlin
Scott, mind taking a quick look for OWNERS?
6 years, 3 months ago (2014-09-05 15:45:24 UTC) #7
sky
LGTM
6 years, 3 months ago (2014-09-05 19:12:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/539543002/60001
6 years, 3 months ago (2014-09-08 22:03:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/7273)
6 years, 3 months ago (2014-09-09 05:39:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/539543002/60001
6 years, 3 months ago (2014-09-09 15:31:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001) as c7ecac2ad0213d039f5a03fe9676153862010ed4
6 years, 3 months ago (2014-09-09 16:09:30 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:38 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1a2fc8cfeb5a38360b622f030f1e756df475cfe
Cr-Commit-Position: refs/heads/master@{#293947}

Powered by Google App Engine
This is Rietveld 408576698