Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 539523003: Add @CalledByNative and @AccessedByNative annotations. (Closed)

Created:
6 years, 3 months ago by simonb (inactive)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add @CalledByNative and @AccessedByNative annotations. Annotate postCallbackOnMainThread() method with @CalledByNative, and LibInfo fields with @AccessedByNative, for ProGuard. BUG=407903 Committed: https://crrev.com/0111c3c794bb2c0bb9b9dce92ec8fdd790d620a8 Cr-Commit-Position: refs/heads/master@{#293168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
simonb (inactive)
6 years, 3 months ago (2014-09-03 16:22:40 UTC) #2
Miguel Garcia
lgtm
6 years, 3 months ago (2014-09-03 16:24:10 UTC) #3
aurimas (slooooooooow)
LGTM, I was just trying to do the same CL myself. Thanks!
6 years, 3 months ago (2014-09-03 16:29:04 UTC) #4
simonb (inactive)
On 2014/09/03 16:29:04, aurimas wrote: > LGTM, I was just trying to do the same ...
6 years, 3 months ago (2014-09-03 16:30:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/539523003/1
6 years, 3 months ago (2014-09-03 16:32:35 UTC) #7
simonb (inactive)
Apparently requires OWNERS lgtm also. nyquist@ or yfriedman@? Thanks.
6 years, 3 months ago (2014-09-03 16:45:33 UTC) #10
nyquist
lgtm
6 years, 3 months ago (2014-09-03 17:05:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/539523003/1
6 years, 3 months ago (2014-09-03 17:12:03 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3bf052113a6b9e07e7aa63593368a96d3af432ff
6 years, 3 months ago (2014-09-03 17:58:33 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0111c3c794bb2c0bb9b9dce92ec8fdd790d620a8
Cr-Commit-Position: refs/heads/master@{#293168}

Powered by Google App Engine
This is Rietveld 408576698