Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 539523002: Revert of Enable highQualityFilter_SSE2 (Closed)

Created:
6 years, 3 months ago by mtklein
Modified:
6 years, 3 months ago
Reviewers:
humper, qiankun
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Enable highQualityFilter_SSE2 (patchset #1 id:1 of https://codereview.chromium.org/525283002/) Reason for revert: Color order looks wrong on Macs: Before: http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/filterbitmap_image_mandrill_16.png/12823183142873462143.png After: http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/filterbitmap_image_mandrill_16.png/13683040204546320578.png Original issue's description: > Enable highQualityFilter_SSE2 > > With SSE2, bitmap_BGRA_8888_A_scale_rotate_bicubic gains about 40% > performance improvement on desktop i7-3770. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b381fa10d8079c58928058bb8a6db32b39f05e51 TBR=humper@google.com,qiankun.miao@intel.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c09b2c49a30fed981283f97476e885b40e53f094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M src/opts/SkBitmapFilter_opts_SSE2.cpp View 2 chunks +35 lines, -33 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/539523002/1
6 years, 3 months ago (2014-09-03 15:56:58 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 15:57:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as c09b2c49a30fed981283f97476e885b40e53f094

Powered by Google App Engine
This is Rietveld 408576698