Issue 539503002: [turbofan] Initial version of ValueNumberingReducer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 539503002: [turbofan] Initial version of ValueNumberingReducer. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Jarin, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Initial version of ValueNumberingReducer. TEST=compiler-unittests,cctest,mjsunit R=mstarzinger@chromium.org, jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23686

Patch Set 1 #

Patch Set 2 : REBASE #

Total comments: 1

Patch Set 3 : REBASE #

Patch Set 4 : Nit and clang-format. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+244 lines, -2 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/compiler.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/js-graph.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/compiler/machine-operator.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/compiler/pipeline.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	src/compiler/value-numbering-reducer.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	src/compiler/value-numbering-reducer.cc	View	1 2 3	1 chunk	+73 lines, -0 lines	0 comments	Download
A	src/compiler/value-numbering-reducer-unittest.cc	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Maybe we should land this initial version and take care of the TypedLoads in a ...

6 years, 3 months ago (2014-09-03 14:12:39 UTC) #1

Michael Starzinger

LGTM. I would be fine with landing it as it is. https://codereview.chromium.org/539503002/diff/20001/src/compiler/value-numbering-reducer.cc File src/compiler/value-numbering-reducer.cc (right): ...

6 years, 3 months ago (2014-09-04 11:07:41 UTC) #2

Benedikt Meurer

6 years, 3 months ago (2014-09-04 11:13:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 23686 (presubmit successful).

Expand Messages | Collapse Messages