Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/test.dart

Issue 539493002: Refactor testing http server in test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/http_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index 89b9d728d07df24cdcd9a7a7dc98bb0e73e76131..7b73b4fd7a70c53d6b004e78d52284281524adc1 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -129,10 +129,13 @@ void testConfigurations(List<Map> configurations) {
List<Future> serverFutures = [];
var testSuites = new List<TestSuite>();
var maxBrowserProcesses = maxProcesses;
- // If the server ports are fixed, then we can only have one configuration.
- assert(((configurations[0]['test_server_port'] == 0) &&
- (configurations[0]['test_server_cross_origin_port'] == 0)) ||
- (configurations.length == 1));
+ if (configurations.length > 1 &&
+ (configurations[0]['test_server_port'] != 0 ||
+ configurations[0]['test_server_cross_origin_port'] != 0)) {
+ print("If the http server ports are specified, only one configuration"
+ " may be run at a time");
+ exit(1);
+ }
for (var conf in configurations) {
Map<String, RegExp> selectors = conf['selectors'];
var useContentSecurityPolicy = conf['csp'];
« no previous file with comments | « no previous file | tools/testing/dart/http_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698