chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc - Issue 539483002: Move all typecasting code to individual screens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

Issue 539483002: Move all typecasting code to individual screens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h ('k') | chrome/browser/chromeos/login/enrollment/enrollment_screen.h » ('j') | chrome/browser/chromeos/login/screen_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

diff --git a/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc b/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

index f786bbed4485d640af7b1f8599bf7b84014fd197..2d49916592d227a1690208d813f016e49240e554 100644

--- a/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

+++ b/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

@@ -16,6 +16,13 @@

namespace chromeos {

+// static

ygorshenin1 2014/09/03 12:58:46 Static methods definitions usually go after ctor a

Denis Kuznetsov (DE-MUC) 2014/09/03 13:16:05 Acknowledged.

+AutoEnrollmentCheckScreen* AutoEnrollmentCheckScreen::Get(

+ ScreenManager* manager) {

ygorshenin1 2014/09/03 12:58:46 Please, add inclusion of chrome/browser/chromeos/l

Denis Kuznetsov (DE-MUC) 2014/09/03 13:16:05 Done.

+ return static_cast<AutoEnrollmentCheckScreen*>(

+ manager->GetScreen(WizardController::kAutoEnrollmentCheckScreenName));

AutoEnrollmentCheckScreen::AutoEnrollmentCheckScreen(

ScreenObserver* observer,

AutoEnrollmentCheckScreenActor* actor)