Used 10ms native buffer size for webrtc audio renderer on Linux and Mac

Used 10ms native buffer size for webrtc audio renderer on Linux and Mac. And also remove some useless buffer size uma stat code.

BUG=410258
TEST=content_unittests --gtest_filter="*WebRtcAudioRenderer*"

Committed: https://crrev.com/c0e2d2d0e4e593125b2a1fac2bb379717556f315
Cr-Commit-Position: refs/heads/master@{#293162}

[no longer working on chromium, 2014-09-03 12:31:46]

xians@chromium.org changed reviewers:
+ henrika@chromium.org

[no longer working on chromium, 2014-09-03 12:32:00]

Henrik, please take a look.

[henrika (OOO until Aug 14), 2014-09-03 12:43:58]

LGTM

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:278: const int frames_per_buffer
=
DVLOG could be useful here.

[henrika (OOO until Aug 14), 2014-09-03 12:44:21]

Please also try Hangouts and some other WebRTC demos.

[no longer working on chromium, 2014-09-03 12:49:27]

I will land it soon if the existing DVLOG is ok.

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:278: const int frames_per_buffer
=
On 2014/09/03 12:43:58, henrika wrote:
> DVLOG could be useful here.

There has already been one DVLOG in the end of GetOptimalBufferSize(), see line
185.

[no longer working on chromium, 2014-09-03 12:49:31]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-09-03 12:49:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/539453003/20001

[tommi (sloooow) - chröme, 2014-09-03 13:22:11]

tommi@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2014-09-03 13:22:11]

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:161: // On Windows, we strive to
open up using native parameters to achieve best
this comment is a bit confusing since there's no #if for windows... does this
apply to the previous line or should there be a further explanation here that
could explain why there isn't a specific #if for windows.

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:172: // cases. Might not be
possible to come up with the perfect solution using
fix indenting here and the next line

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.h (right):

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.h:102: int buffer_size() const {
return sink_params_.frames_per_buffer(); }
rename to frames_per_buffer for consistency.  buffer_size() isn't really correct
since this doesn't reflect number of bytes.

[no longer working on chromium, 2014-09-03 13:30:36]

The CQ bit was unchecked by xians@chromium.org

[no longer working on chromium, 2014-09-03 14:34:50]

Tommi, another look?

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:161: // On Windows, we strive to
open up using native parameters to achieve best
On 2014/09/03 13:22:11, tommi wrote:
> this comment is a bit confusing since there's no #if for windows... does this
> apply to the previous line or should there be a further explanation here that
> could explain why there isn't a specific #if for windows.

I moved the comment up and explained by we don't have #if case for windows.

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:172: // cases. Might not be
possible to come up with the perfect solution using
On 2014/09/03 13:22:11, tommi wrote:
> fix indenting here and the next line

Done.

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.h (right):

https://codereview.chromium.org/539453003/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.h:102: int buffer_size() const {
return sink_params_.frames_per_buffer(); }
On 2014/09/03 13:22:11, tommi wrote:
> rename to frames_per_buffer for consistency.  buffer_size() isn't really
correct
> since this doesn't reflect number of bytes.

Done.

[tommi (sloooow) - chröme, 2014-09-03 14:45:03]

lgtm, but I think you have an unintended paste in there that will break on
android.

https://codereview.chromium.org/539453003/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/539453003/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:174: int frames_per_10ms =
Unintended?

[no longer working on chromium, 2014-09-03 14:49:36]

https://codereview.chromium.org/539453003/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/539453003/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc_audio_renderer.cc:174: int frames_per_10ms =
On 2014/09/03 14:45:02, tommi wrote:
> Unintended?

Thanks, the change was not saved in the editor.

[no longer working on chromium, 2014-09-03 14:49:40]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-09-03 14:50:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/539453003/60001

[commit-bot: I haz the power, 2014-09-03 16:47:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-09-03 17:30:50]

Committed patchset #4 (id:60001) as 39d1cfb8bba7a64e72fc4829633e4f541d472958

[commit-bot: I haz the power, 2014-09-10 03:26:35]

Patchset 4 (id:??) landed as
https://crrev.com/c0e2d2d0e4e593125b2a1fac2bb379717556f315
Cr-Commit-Position: refs/heads/master@{#293162}