Source/core/events/EventTarget.cpp - Issue 539453002: Crashed at ImageEventListener::cast & ConditionEventListener::cast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/EventTarget.cpp

Issue 539453002: Crashed at ImageEventListener::cast & ConditionEventListener::cast (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/images/image-document-remove-listener-expected.txt ('k') | Source/core/events/RegisteredEventListener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/events/EventTarget.cpp

diff --git a/Source/core/events/EventTarget.cpp b/Source/core/events/EventTarget.cpp

index 61084c36208b4a678a6ef7a595ddd771cad24473..c341ece47ad271aa4434fb08cd67bc2ffb71a320 100644

--- a/Source/core/events/EventTarget.cpp

+++ b/Source/core/events/EventTarget.cpp

@@ -108,6 +108,11 @@ bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<Eve

bool EventTarget::removeEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)

{

+ // FIXME: listener null check should throw TypeError (and be done in

+ // generated bindings), but breaks legacy content. http://crbug.com/249598

+ if (!listener)

+ return false;

EventTargetData* d = eventTargetData();

if (!d)

return false;