Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 539413002: Add a WebRemoteFrameClient interface to public/web (Closed)

Created:
6 years, 3 months ago by Nate Chapin
Modified:
6 years, 3 months ago
Reviewers:
nasko, abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Project:
blink
Visibility:
Public.

Description

Add a WebRemoteFrameClient interface to public/web This interface temporarily subclasses WebFrameClient to ease the transition, and will be implemented by content::RenderFrameProxy. Add postMessageEvent(), to be properly plumbed in a followup patch. This is step 1 of 3 on crubg.com/411066 BUG=411066 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181569

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A public/web/WebRemoteFrameClient.h View 1 chunk +24 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (6 generated)
Nate Chapin
https://codereview.chromium.org/539413002/diff/1/public/web/WebRemoteFrameClient.h File public/web/WebRemoteFrameClient.h (right): https://codereview.chromium.org/539413002/diff/1/public/web/WebRemoteFrameClient.h#newcode12 public/web/WebRemoteFrameClient.h:12: class WebRemoteFrameClient : public WebFrameClient { This inheritance is ...
6 years, 3 months ago (2014-09-04 23:16:48 UTC) #2
nasko
LGTM
6 years, 3 months ago (2014-09-04 23:22:20 UTC) #3
abarth-chromium
LGTM
6 years, 3 months ago (2014-09-05 18:17:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/539413002/1
6 years, 3 months ago (2014-09-05 18:20:43 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 00:21:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/539413002/1
6 years, 3 months ago (2014-09-08 16:54:17 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 17:01:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181569

Powered by Google App Engine
This is Rietveld 408576698