Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 539403002: Fix scroll-related issues. (Closed)

Created:
6 years, 3 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
garykac1, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix scroll-related issues. This fixes two related issues: * Scrolling was broken in apps v2, due to window-body div not being full-height. * Scrolling was broken post-disconnect, due to the addition of an explicit scroller node, separate from the body. * The dialog screen was off by 1px, due to the addition of the window-body div. Since this has broken a few times now, I plan to add a browser to test to verify the behaviour, but I don't want to hold up this CL for that. BUG=251443 Committed: https://crrev.com/14f7b1a1738a68e55e816dc8f75fb75d0202c514 Cr-Commit-Position: refs/heads/master@{#293431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M remoting/webapp/html/template_main.html View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/main.css View 2 chunks +0 lines, -9 lines 0 comments Download
M remoting/webapp/ui_mode.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jamie
6 years, 3 months ago (2014-09-04 22:52:45 UTC) #2
garykac1
lgtm
6 years, 3 months ago (2014-09-04 22:58:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/539403002/1
6 years, 3 months ago (2014-09-04 23:02:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as aa6cd4755ca056d747613b775bd5164bc2facb45
6 years, 3 months ago (2014-09-05 04:10:11 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14f7b1a1738a68e55e816dc8f75fb75d0202c514
Cr-Commit-Position: refs/heads/master@{#293431}

Powered by Google App Engine
This is Rietveld 408576698