Chromium Code Reviews Chromium Code Reviews
Issue 539353004:
DevTools: [Documentation] Update parser for WikiText (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 | 1 |
| 2 Running: testWikiParser | 2 Running: testWikiParser |
| 3 "{{A|Code={{=}} }}" is parsed | |
| 4 { | |
| 5 A : { | |
| 6 Code : "=" | |
| 7 } | |
| 8 } | |
| 9 "{{A|B=C}}" is parsed | |
| 10 { | |
| 11 A : { | |
| 12 B : { | |
| 13 _children : [ | |
| 14 { | |
| 15 _children : [ | |
| 16 { | |
| 17 _isHighlighted : false | |
| 18 _text : "C" | |
| 19 _type : "PlainText" | |
| 20 } | |
| 21 ] | |
| 22 _hasBullet : false | |
| 23 _type : "Block" | |
| 24 } | |
| 25 ] | |
| 26 _hasBullet : false | |
| 27 _type : "Block" | |
| 28 } | |
| 29 } | |
| 30 } | |
| 3 "{{A|B={{C|D=blablabla}}}}" is parsed | 31 "{{A|B={{C|D=blablabla}}}}" is parsed |
| 4 { | 32 { |
| 5 A : { | 33 A : { |
| 6 B : { | 34 B : [ |
| 7 C : { | 35 { |
| 8 D : "blablabla" | 36 C : { |
| 37 D : { | |
| 38 _children : [ | |
| 39 { | |
| 40 _children : [ | |
| 41 { | |
| 42 _isHighlighted : false | |
| 43 _text : "blablabla" | |
| 44 _type : "PlainText" | |
| 45 } | |
| 46 ] | |
| 47 _hasBullet : false | |
| 48 _type : "Block" | |
| 49 } | |
| 50 ] | |
| 51 _hasBullet : false | |
| 52 _type : "Block" | |
| 53 } | |
| 54 } | |
| 9 } | 55 } |
| 56 ] | |
| 57 } | |
| 58 } | |
| 59 "{{A|B={{C|D=bla}}|x=y}}" is parsed | |
| 60 { | |
| 61 A : { | |
| 62 B : [ | |
| 63 { | |
| 64 C : { | |
| 65 D : { | |
| 66 _children : [ | |
| 67 { | |
| 68 _children : [ | |
| 69 { | |
| 70 _isHighlighted : false | |
| 71 _text : "bla" | |
| 72 _type : "PlainText" | |
| 73 } | |
| 74 ] | |
| 75 _hasBullet : false | |
| 76 _type : "Block" | |
| 77 } | |
| 78 ] | |
| 79 _hasBullet : false | |
| 80 _type : "Block" | |
| 81 } | |
| 82 } | |
| 83 } | |
| 84 ] | |
| 85 x : { | |
| 86 _children : [ | |
| 87 { | |
| 88 _children : [ | |
| 89 { | |
| 90 _isHighlighted : false | |
| 91 _text : "y" | |
| 92 _type : "PlainText" | |
| 93 } | |
| 94 ] | |
| 95 _hasBullet : false | |
| 96 _type : "Block" | |
| 97 } | |
| 98 ] | |
| 99 _hasBullet : false | |
| 100 _type : "Block" | |
| 10 } | 101 } |
| 11 } | 102 } |
| 12 } | 103 } |
| 13 "{{CS|Init=black|Values={{CSS Property Value | 104 "{{CS|Init=black|Values={{CSS Property Value |
| 14 |Data Type=color | 105 |Data Type=color |
| 15 |Description=[[css/color|CSS color value]]}} | 106 |Description= [[css/color|CSS color value]]}} |
| 16 }}" is parsed | 107 }}" is parsed |
| 17 { | 108 { |
| 18 CS : { | 109 CS : { |
| 19 Init : "black" | 110 Init : { |
| 20 Values : { | 111 _children : [ |
| 21 CSS Property Value : { | 112 { |
| 22 Data Type : "color" | 113 _children : [ |
| 23 Description : "[[css/color|CSS color value]]" | 114 { |
| 115 _isHighlighted : false | |
| 116 _text : "black" | |
| 117 _type : "PlainText" | |
| 118 } | |
| 119 ] | |
| 120 _hasBullet : false | |
| 121 _type : "Block" | |
| 122 } | |
| 123 ] | |
| 124 _hasBullet : false | |
| 125 _type : "Block" | |
| 126 } | |
| 127 Values : [ | |
| 128 { | |
| 129 CSS Property Value : { | |
| 130 Data Type : { | |
| 131 _children : [ | |
| 132 { | |
| 133 _children : [ | |
| 134 { | |
| 135 _isHighlighted : false | |
| 136 _text : "color" | |
| 137 _type : "PlainText" | |
| 138 } | |
| 139 ] | |
| 140 _hasBullet : false | |
| 141 _type : "Block" | |
| 142 } | |
| 143 ] | |
| 144 _hasBullet : false | |
| 145 _type : "Block" | |
| 146 } | |
| 147 Description : { | |
| 148 _children : [ | |
| 149 { | |
| 150 _children : [ | |
| 151 { | |
| 152 _children : [ | |
| 153 { | |
| 154 _children : [ | |
| 155 { | |
| 156 _isHighlighted : false | |
| 157 _text : "CSS color value " | |
| 158 _type : "PlainText" | |
| 159 } | |
| 160 ] | |
| 161 _type : "Inline" | |
| 162 } | |
| 163 ] | |
| 164 _type : "Link" | |
| 165 _url : "css/color" | |
| 166 } | |
| 167 ] | |
| 168 _hasBullet : false | |
| 169 _type : "Block" | |
| 170 } | |
| 171 ] | |
| 172 _hasBullet : false | |
| 173 _type : "Block" | |
| 174 } | |
| 175 } | |
| 24 } | 176 } |
| 25 } | 177 ] |
| 26 } | 178 } |
| 27 } | 179 } |
| 28 "{{A}}" is parsed | 180 "{{A}}" is parsed |
| 29 { | 181 { |
| 30 A : { | 182 A : { |
| 31 } | 183 } |
| 32 } | 184 } |
| 33 "{{A|B=bla<a=c>bla}}" is parsed | 185 "{{A|B= [[google.com{{!}}Google]]}}" is parsed |
| 34 { | 186 { |
| 35 A : { | 187 A : { |
| 36 B : "bla<a=c>bla" | 188 B : { |
| 37 } | 189 _children : [ |
| 38 } | 190 { |
| 39 "{{A}}" is parsed | 191 _children : [ |
| 40 { | 192 { |
| 41 A : { | 193 _children : [ |
| 194 { | |
| 195 _children : [ | |
| 196 { | |
| 197 _isHighlighted : false | |
| 198 _text : "Google" | |
| 199 _type : "PlainText" | |
| 200 } | |
| 201 ] | |
| 202 _type : "Inline" | |
| 203 } | |
| 204 ] | |
| 205 _type : "Link" | |
| 206 _url : "google.com" | |
| 207 } | |
| 208 ] | |
| 209 _hasBullet : false | |
| 210 _type : "Block" | |
| 211 } | |
| 212 ] | |
| 213 _hasBullet : false | |
| 214 _type : "Block" | |
| 215 } | |
| 42 } | 216 } |
| 43 } | 217 } |
| 44 "{{AbC|xyz | 218 "{{AbC|xyz |
| 45 » \r}}" is parsed | 219 » \r}}" is parsed |
| 46 { | 220 { |
| 47 AbC : "xyz | 221 AbC : { |
| 48 » " | 222 _children : [ |
| 223 { | |
| 224 _children : [ | |
| 225 { | |
| 226 _isHighlighted : false | |
| 227 _text : "xyz" | |
| 228 _type : "PlainText" | |
| 229 } | |
| 230 ] | |
| 231 _hasBullet : false | |
| 232 _type : "Block" | |
| 233 } | |
| 234 ] | |
| 235 _hasBullet : false | |
| 236 _type : "Block" | |
| 237 } | |
| 238 } | |
| 239 "{{External_Attribution|MSDN_link=[http://msdn.microsoft.com/en-us/library/ie/ms 536365(v=vs.85).aspx cloneNode Method]|HTML5Rocks_link=}}" is parsed | |
| 240 { | |
| 241 External_Attribution : { | |
| 242 MSDN_link : { | |
| 243 _children : [ | |
| 244 { | |
| 245 _children : [ | |
| 246 { | |
| 247 _isHighlighted : false | |
| 248 _text : "[http://msdn.microsoft.com/en-us/library/ie /ms536365(v=vs.85).aspx cloneNode Method]" | |
|
lushnikov
2014/09/09 12:40:45
and this is not going to be rendered as a link.. h
iliia
2014/09/09 14:29:17
Yes, because it's a link without space in the begi
| |
| 249 _type : "PlainText" | |
| 250 } | |
| 251 ] | |
| 252 _hasBullet : false | |
| 253 _type : "Block" | |
| 254 } | |
| 255 ] | |
| 256 _hasBullet : false | |
| 257 _type : "Block" | |
| 258 } | |
| 259 } | |
| 260 } | |
| 261 "{{JS_Syntax|Formats={{JS Syntax Format|Format='''JSON.stringify(''' value [ , r eplacer] [ , space] ''')'''}} | |
| 262 }}" is parsed | |
| 263 { | |
| 264 JS_Syntax : { | |
| 265 Formats : [ | |
| 266 { | |
| 267 JS Syntax Format : { | |
| 268 Format : { | |
| 269 _children : [ | |
| 270 { | |
| 271 _children : [ | |
| 272 { | |
| 273 _isHighlighted : true | |
| 274 _text : "JSON.stringify(" | |
| 275 _type : "PlainText" | |
| 276 } | |
| 277 { | |
| 278 _isHighlighted : false | |
| 279 _text : " value" | |
| 280 _type : "PlainText" | |
| 281 } | |
| 282 { | |
| 283 _children : [ | |
| 284 ] | |
| 285 _type : "Link" | |
| 286 _url : " , replacer" | |
|
lushnikov
2014/09/09 12:40:45
so it looks like we gonna parse this as a link? Th
iliia
2014/09/09 14:29:17
Yes, because there is a brackets with a space in t
| |
| 287 } | |
| 288 { | |
| 289 _children : [ | |
| 290 ] | |
| 291 _type : "Link" | |
| 292 _url : " , space" | |
| 293 } | |
| 294 { | |
| 295 _isHighlighted : false | |
| 296 _text : " " | |
| 297 _type : "PlainText" | |
| 298 } | |
| 299 { | |
| 300 _isHighlighted : true | |
| 301 _text : ")" | |
| 302 _type : "PlainText" | |
| 303 } | |
| 304 ] | |
| 305 _hasBullet : false | |
| 306 _type : "Block" | |
| 307 } | |
| 308 ] | |
| 309 _hasBullet : false | |
| 310 _type : "Block" | |
| 311 } | |
| 312 } | |
| 313 } | |
| 314 ] | |
| 315 } | |
| 49 } | 316 } |
|
lushnikov
2014/09/09 12:40:45
lets add a test for the table to make sure we don'
iliia
2014/09/09 14:29:17
Done.
| |
| 50 | 317 |
| 51 Running: testJS | 318 Running: testJS |
| 52 { | 319 { |
| 53 examples : [ | 320 examples : [ |
| 54 ] | 321 ] |
| 55 parameters : [ | 322 parameters : [ |
| 56 ] | 323 ] |
| 57 remarks : { | 324 remarks : { |
| 58 _children : [ | 325 _children : [ |
| 59 { | 326 { |
| (...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 116 _type : "PlainText" | 383 _type : "PlainText" |
| 117 } | 384 } |
| 118 ] | 385 ] |
| 119 _hasBullet : false | 386 _hasBullet : false |
| 120 _type : "Block" | 387 _type : "Block" |
| 121 } | 388 } |
| 122 ] | 389 ] |
| 123 _hasBullet : false | 390 _hasBullet : false |
| 124 _type : "Block" | 391 _type : "Block" |
| 125 } | 392 } |
| 393 summary : undefined | |
| 126 } | 394 } |
| 127 | 395 |
| 128 Running: testSmall | 396 Running: testSmall |
| 129 { | 397 { |
| 130 examples : [ | 398 examples : [ |
| 131 ] | 399 ] |
| 132 parameters : [ | 400 parameters : [ |
| 133 ] | 401 ] |
| 402 remarks : null | |
| 134 summary : { | 403 summary : { |
| 135 _children : [ | 404 _children : [ |
| 136 { | 405 { |
| 137 _children : [ | 406 _children : [ |
| 138 { | 407 { |
| 139 _isHighlighted : false | 408 _isHighlighted : false |
| 140 _text : "blabla " | 409 _text : "blabla " |
| 141 _type : "PlainText" | 410 _type : "PlainText" |
| 142 } | 411 } |
| 143 { | 412 { |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 154 _type : "Block" | 423 _type : "Block" |
| 155 } | 424 } |
| 156 } | 425 } |
| 157 | 426 |
| 158 Running: testHighlightAndLink | 427 Running: testHighlightAndLink |
| 159 { | 428 { |
| 160 examples : [ | 429 examples : [ |
| 161 ] | 430 ] |
| 162 parameters : [ | 431 parameters : [ |
| 163 ] | 432 ] |
| 433 remarks : null | |
| 164 summary : { | 434 summary : { |
| 165 _children : [ | 435 _children : [ |
| 166 { | 436 { |
| 167 _children : [ | 437 _children : [ |
| 168 { | 438 { |
| 169 _isHighlighted : false | 439 _isHighlighted : false |
| 170 _text : "The " | 440 _text : "The " |
| 171 _type : "PlainText" | 441 _type : "PlainText" |
| 172 } | 442 } |
| 173 { | 443 { |
| (...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 262 _type : "Block" | 532 _type : "Block" |
| 263 } | 533 } |
| 264 } | 534 } |
| 265 | 535 |
| 266 Running: testNamedLink | 536 Running: testNamedLink |
| 267 { | 537 { |
| 268 examples : [ | 538 examples : [ |
| 269 ] | 539 ] |
| 270 parameters : [ | 540 parameters : [ |
| 271 ] | 541 ] |
| 542 remarks : null | |
| 272 summary : { | 543 summary : { |
| 273 _children : [ | 544 _children : [ |
| 274 { | 545 { |
| 275 _children : [ | 546 _children : [ |
| 276 { | 547 { |
| 277 _children : [ | 548 _children : [ |
| 278 { | 549 { |
| 279 _children : [ | 550 _children : [ |
| 280 { | 551 { |
| 281 _isHighlighted : false | 552 _isHighlighted : false |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 298 _type : "Block" | 569 _type : "Block" |
| 299 } | 570 } |
| 300 } | 571 } |
| 301 | 572 |
| 302 Running: testBullet | 573 Running: testBullet |
| 303 { | 574 { |
| 304 examples : [ | 575 examples : [ |
| 305 ] | 576 ] |
| 306 parameters : [ | 577 parameters : [ |
| 307 ] | 578 ] |
| 579 remarks : null | |
| 308 summary : { | 580 summary : { |
| 309 _children : [ | 581 _children : [ |
| 310 { | 582 { |
| 311 _children : [ | 583 _children : [ |
| 312 { | 584 { |
| 313 _isHighlighted : false | 585 _isHighlighted : false |
| 314 _text : "blabla" | 586 _text : "blabla" |
| 315 _type : "PlainText" | 587 _type : "PlainText" |
| 316 } | 588 } |
| 317 ] | 589 ] |
| (...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 437 console.log(Object.keys(my_array)); | 709 console.log(Object.keys(my_array)); |
| 438 | 710 |
| 439 // Output | 711 // Output |
| 440 // ["0"]" | 712 // ["0"]" |
| 441 _type : "CodeBlock" | 713 _type : "CodeBlock" |
| 442 } | 714 } |
| 443 ] | 715 ] |
| 444 _hasBullet : false | 716 _hasBullet : false |
| 445 _type : "Block" | 717 _type : "Block" |
| 446 } | 718 } |
| 719 summary : undefined | |
| 447 } | 720 } |
| 448 | 721 |
| 449 Running: testComplexLinkName | 722 Running: testComplexLinkName |
| 450 { | 723 { |
| 451 examples : [ | 724 examples : [ |
| 452 ] | 725 ] |
| 453 parameters : [ | 726 parameters : [ |
| 454 ] | 727 ] |
| 728 remarks : null | |
| 455 summary : { | 729 summary : { |
| 456 _children : [ | 730 _children : [ |
| 457 { | 731 { |
| 458 _children : [ | 732 _children : [ |
| 459 { | 733 { |
| 460 _children : [ | 734 _children : [ |
| 461 { | 735 { |
| 462 _children : [ | 736 _children : [ |
| 463 { | 737 { |
| 464 _isHighlighted : false | 738 _isHighlighted : false |
| (...skipping 26 matching lines...) Expand all Loading... | |
| 491 _type : "Block" | 765 _type : "Block" |
| 492 } | 766 } |
| 493 } | 767 } |
| 494 | 768 |
| 495 Running: testCodeInsideBullet | 769 Running: testCodeInsideBullet |
| 496 { | 770 { |
| 497 examples : [ | 771 examples : [ |
| 498 ] | 772 ] |
| 499 parameters : [ | 773 parameters : [ |
| 500 ] | 774 ] |
| 775 remarks : null | |
| 501 summary : { | 776 summary : { |
| 502 _children : [ | 777 _children : [ |
| 503 { | 778 { |
| 504 _children : [ | 779 _children : [ |
| 505 { | 780 { |
| 506 _isHighlighted : false | 781 _isHighlighted : false |
| 507 _text : "some text " | 782 _text : "some text " |
| 508 _type : "PlainText" | 783 _type : "PlainText" |
| 509 } | 784 } |
| 510 { | 785 { |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 521 _hasBullet : true | 796 _hasBullet : true |
| 522 _type : "Block" | 797 _type : "Block" |
| 523 } | 798 } |
| 524 ] | 799 ] |
| 525 _hasBullet : false | 800 _hasBullet : false |
| 526 _type : "Block" | 801 _type : "Block" |
| 527 } | 802 } |
| 528 } | 803 } |
| 529 | 804 |
| 530 Running: testInvalidInput | 805 Running: testInvalidInput |
| 531 error: Can't parse remarks | |
| 532 [object Object] | 806 [object Object] |
| 533 | 807 |
| 534 Running: testLinkInsideCode | 808 Running: testLinkInsideCode |
| 535 { | 809 { |
| 536 examples : [ | 810 examples : [ |
| 537 ] | 811 ] |
| 538 parameters : [ | 812 parameters : [ |
| 539 ] | 813 ] |
| 814 remarks : null | |
| 540 summary : { | 815 summary : { |
| 541 _children : [ | 816 _children : [ |
| 542 { | 817 { |
| 543 _children : [ | 818 _children : [ |
| 544 { | 819 { |
| 545 _children : [ | 820 _children : [ |
| 546 { | 821 { |
| 547 _children : [ | 822 _children : [ |
| 548 { | 823 { |
| 549 _children : [ | 824 _children : [ |
| (...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 628 ] | 903 ] |
| 629 _hasBullet : false | 904 _hasBullet : false |
| 630 _type : "Block" | 905 _type : "Block" |
| 631 } | 906 } |
| 632 language : "HTML" | 907 language : "HTML" |
| 633 liveUrl : "http://samples.msdn.microsoft.com/workshop/samples/author /dhtml/refs/insertBefore.htm" | 908 liveUrl : "http://samples.msdn.microsoft.com/workshop/samples/author /dhtml/refs/insertBefore.htm" |
| 634 } | 909 } |
| 635 ] | 910 ] |
| 636 parameters : [ | 911 parameters : [ |
| 637 ] | 912 ] |
| 913 remarks : null | |
| 914 summary : undefined | |
| 638 } | 915 } |
| 639 | 916 |
| 640 Running: testJsMethod | 917 Running: testJsMethod |
| 641 { | 918 { |
| 642 examples : [ | 919 examples : [ |
| 643 ] | 920 ] |
| 644 methods : { | 921 methods : { |
| 645 returnValueDescription : "The inserted node." | 922 returnValueDescription : "The inserted node." |
| 646 returnValueName : "DOM Node" | 923 returnValueName : "DOM Node" |
| 647 } | 924 } |
| (...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 684 _type : "Block" | 961 _type : "Block" |
| 685 } | 962 } |
| 686 ] | 963 ] |
| 687 _hasBullet : false | 964 _hasBullet : false |
| 688 _type : "Block" | 965 _type : "Block" |
| 689 } | 966 } |
| 690 name : "refChild" | 967 name : "refChild" |
| 691 optional : true | 968 optional : true |
| 692 } | 969 } |
| 693 ] | 970 ] |
| 971 remarks : null | |
| 972 summary : undefined | |
| 694 } | 973 } |
| 695 | 974 |
| 696 Running: testLinkWithoutSpace | 975 Running: testLinkWithoutSpace |
| 697 error: Can't parse summary | 976 Expected error: Error: Two closing braces expected; found WRONG_LINK |
| 698 { | |
| 699 examples : [ | |
| 700 ] | |
| 701 parameters : [ | |
| 702 ] | |
| 703 summary : null | |
| 704 } | |
| 705 | 977 |
| OLD | NEW |
