DevTools: [Documentation] Update parser for WikiText

Source/devtools/front_end/documentation/DocumentationView.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.View}
  */
 WebInspector.DocumentationView = function()
 {
     WebInspector.View.call(this);
     this.element.classList.add("documentation-view");
     this.registerRequiredCSS("documentationView.css");
 }
 
 /**
  * @param {string} url
  * @param {string} searchItem
  */
 WebInspector.DocumentationView.showDocumentationURL = function(url, searchItem)
 {
     if (!WebInspector.DocumentationView._view)
         WebInspector.DocumentationView._view = new WebInspector.DocumentationView();
     var view = WebInspector.DocumentationView._view;
+    view.element.removeChildren();

[lushnikov, 2014/09/08 14:08:29]

why do we need this?

[iliia, 2014/09/08 15:20:49]

We discuss it with offline.
On 2014/09/08 14:08:29, lushnikov wrote:

     WebInspector.inspectorView.showCloseableViewInDrawer("documentation", WebInspector.UIString("Documentation"), view);
     view.showDocumentation(url, searchItem);
 }
 
 WebInspector.DocumentationView._languageToMimeType = {
     "javascript": "text/javascript",
     "html": "text/html"
 };
 
 WebInspector.DocumentationView.prototype = {
@@ skipping 19 matching lines @@
     _createArticle: function(searchItem, responseText)
     {
         var json = JSON.parse(responseText);
         var pages = json["query"]["pages"];
         var wikiKeys = Object.keys(pages);
         if (wikiKeys.length === 1 && wikiKeys[0] === "-1") {
             this._createEmptyPage();
             return;
         }
         var wikiMarkupText = pages[wikiKeys[0]]["revisions"]["0"]["*"];
-        var article = WebInspector.JSArticle.parse(wikiMarkupText);
+        try {
+            var article = WebInspector.JSArticle.parse(wikiMarkupText);
+        } catch (error) {
+            this._createPageForError(error);

[lushnikov, 2014/09/08 14:08:29]

let's fallback to empty page for now. We'll do a "file a bug" fallback if we
have enough time

[iliia, 2014/09/08 15:20:50]

Done.

+        }
         if (!article) {
             this._createEmptyPage();
             return;
         }
 
+        this.element.removeChildren();

[lushnikov, 2014/09/08 14:08:29]

why this change?

[iliia, 2014/09/08 15:20:49]

We discuss it offline.
On 2014/09/08 14:08:29, lushnikov wrote:

         var renderer = new WebInspector.DocumentationView.Renderer(article, searchItem);
-        this.element.removeChildren();
         this.element.appendChild(renderer.renderJSArticle());
     },
 
     _createEmptyPage: function()
     {
         this.element.removeChildren();
         var pageTitle = this.element.createChild("div", "documentation-page-title");
         pageTitle.textContent = WebInspector.UIString("Documentation not available");
     },
 
+    _createPageForError: function(message)
+    {
+        this.element.removeChildren();
+        var pageTitle = this.element.createChild("div", "documentation-page-title");
+        pageTitle.textContent = WebInspector.UIString("We have some problems");
+        var error = this.element.createChild("div", "documentation-text");
+        error.textContent = WebInspector.UIString("Error message: " + message);
+    },
+
     __proto__: WebInspector.View.prototype
 }
 
 /**
  * @constructor
  * @param {!WebInspector.JSArticle} article
  * @param {string} searchItem
  */
 WebInspector.DocumentationView.Renderer = function(article, searchItem)
 {
@@ skipping 128 matching lines @@
             code.textContent = examples[i].code;
             if (!examples[i].language)
                 continue;
             var syntaxHighlighter = new WebInspector.DOMSyntaxHighlighter(WebInspector.DocumentationView._languageToMimeType[examples[i].language.toLowerCase()], true);
             syntaxHighlighter.syntaxHighlightNode(code);
         }
     },
 
     /**
      * @param {!WebInspector.WikiParser.ArticleElement} article
-     * @return {!Element}
+     * @return {?Element}
      */
     _renderBlock: function(article)
     {
         var element;
         var elementTypes = WebInspector.WikiParser.ArticleElement.Type;
 
         switch (article.type()) {
         case elementTypes.Inline:
             element = document.createElement("span");
-            break;

[lushnikov, 2014/09/08 14:08:30]

I believe you still want "break" statement

[iliia, 2014/09/08 15:20:49]

Done.

         case elementTypes.Link:
             element = document.createElementWithClass("a", "documentation-link");
             element.href = article.url();
             if (!article.children().length)
                 element.textContent = article.url();
             break;
         case elementTypes.Code:
             element = document.createElementWithClass("span", "documentation-code-tag");
             break;
         case elementTypes.CodeBlock:
@@ skipping 86 matching lines @@
         function computeDescriptors(column)
         {
             var token = textEditor.tokenAtTextPosition(textSelection.startLine, column);
             if (!token)
                 return [];
             var tokenText = textEditor.line(textSelection.startLine).substring(token.startColumn, token.endColumn);
             return urlProvider.itemDescriptors(tokenText);
         }
     }
 }