DevTools: [Documentation] Update parser for WikiText

Source/devtools/front_end/documentation/DocumentationView.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.View}
  */
 WebInspector.DocumentationView = function()
 {
     WebInspector.View.call(this);
     this.element.classList.add("documentation-view");
     this.registerRequiredCSS("documentationView.css");
 }
 
 /**
  * @param {string} url
  * @param {string} searchItem
  */
 WebInspector.DocumentationView.showDocumentationURL = function(url, searchItem)
 {
     if (!WebInspector.DocumentationView._view)
         WebInspector.DocumentationView._view = new WebInspector.DocumentationView();
     var view = WebInspector.DocumentationView._view;
+    view.element.removeChildren();
     WebInspector.inspectorView.showCloseableViewInDrawer("documentation", WebInspector.UIString("Documentation"), view);
     view.showDocumentation(url, searchItem);
 }
 
 WebInspector.DocumentationView._languageToMimeType = {
     "javascript": "text/javascript",
     "html": "text/html"
 };
 
 WebInspector.DocumentationView.prototype = {
@@ skipping 19 matching lines @@
     _createArticle: function(searchItem, responseText)
     {
         var json = JSON.parse(responseText);
         var pages = json["query"]["pages"];
         var wikiKeys = Object.keys(pages);
         if (wikiKeys.length === 1 && wikiKeys[0] === "-1") {
             this._createEmptyPage();
             return;
         }
         var wikiMarkupText = pages[wikiKeys[0]]["revisions"]["0"]["*"];
-        var article = WebInspector.JSArticle.parse(wikiMarkupText);
+        var article;
+        try {
+            article = WebInspector.JSArticle.parse(wikiMarkupText);
+        } catch (error) {
+            this._createEmptyPage();

[apavlov, 2014/09/10 14:09:23]

This and the following line can be dropped:
if (!article) {...} below will _createEmptyPage the second time otherwise.

[iliia, 2014/09/11 09:26:30]

Done.

+            article = null;
+            console.error(error);

[apavlov, 2014/09/10 14:09:23]

Should this be error.message?

[iliia, 2014/09/11 09:26:30]

Done.

[apavlov, 2014/09/11 10:40:26]

Not done - still, the "error" object is used instead of error.message

[iliia, 2014/09/11 13:26:28]

Done.

+        }
         if (!article) {
             this._createEmptyPage();
             return;
         }
 
+        this.element.removeChildren();
         var renderer = new WebInspector.DocumentationView.Renderer(article, searchItem);
-        this.element.removeChildren();
         this.element.appendChild(renderer.renderJSArticle());
     },
 
     _createEmptyPage: function()
     {
         this.element.removeChildren();
         var emptyPage = this.element.createChild("div", "documentation-empty-page fill");
         var pageTitle = emptyPage.createChild("div", "documentation-not-found");
         pageTitle.textContent = "No documentation found.";
         emptyPage.createChild("div", "documentation-empty-page-align");
@@ skipping 169 matching lines @@
             code.textContent = examples[i].code;
             if (!examples[i].language)
                 continue;
             var syntaxHighlighter = new WebInspector.DOMSyntaxHighlighter(WebInspector.DocumentationView._languageToMimeType[examples[i].language.toLowerCase()], true);
             syntaxHighlighter.syntaxHighlightNode(code);
         }
     },
 
     /**
      * @param {!WebInspector.WikiParser.ArticleElement} article
-     * @return {!Element}
+     * @return {?Element}

[apavlov, 2014/09/10 14:09:23]

Any reason for this being nullable?

[iliia, 2014/09/11 09:26:30]

element could be undefined if something's going wrong.
On 2014/09/10 14:09:23, apavlov (OOO until Sept.19) wrote:

      */
     _renderBlock: function(article)
     {
         var element;
         var elementTypes = WebInspector.WikiParser.ArticleElement.Type;
 
         switch (article.type()) {
         case elementTypes.Inline:
             element = document.createElement("span");
             break;
@@ skipping 10 matching lines @@
             element = document.createElementWithClass("pre", "documentation-code source-code");
             element.textContent = article.code();
             break;
         case elementTypes.PlainText:
             element = document.createElement("span");
             element.textContent = article.text();
             if (article.isHighlighted())
                 element.classList.add("documentation-highlighted-text");
             break;
         default:
             console.error("Unknown ArticleElement type " + article.type());

[apavlov, 2014/09/10 14:09:23]

Is this intentionally missing a break; ? Or should this go last in the switch?
What should be returned in this case?

[iliia, 2014/09/11 09:26:30]

Done.

         case elementTypes.Block:
             element = document.createElement(article.hasBullet() ? "li" : "p");
             break;
         }
 
         if (article instanceof WebInspector.WikiParser.Block || article instanceof WebInspector.WikiParser.Inline) {

[apavlov, 2014/09/10 14:09:23]

Now we can check article.type()

[iliia, 2014/09/11 09:26:30]

Done.

             for (var i = 0; i < article.children().length; ++i) {
                 var child = this._renderBlock(article.children()[i]);
                 if (child)
                     element.appendChild(child);
             }
         }
 
         return element;
     }
 }
@@ skipping 61 matching lines @@
         function computeDescriptors(column)
         {
             var token = textEditor.tokenAtTextPosition(textSelection.startLine, column);
             if (!token)
                 return [];
             var tokenText = textEditor.line(textSelection.startLine).substring(token.startColumn, token.endColumn);
             return urlProvider.itemDescriptors(tokenText);
         }
     }
 }