Make the timestamp unroll offset consistent accross PES pids.

media/formats/mp2t/es_parser_adts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/mp2t/es_parser_adts.h"
 
 #include <list>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 141 matching lines @@
 
     // TODO(wolenetz/acolwell): Validate and use a common cross-parser TrackId
     // type and allow multiple audio tracks. See https://crbug.com/341581.
     scoped_refptr<StreamParserBuffer> stream_parser_buffer =
         StreamParserBuffer::CopyFrom(
             adts_frame.data,
             adts_frame.size,
             is_key_frame,
             DemuxerStream::AUDIO, 0);
     stream_parser_buffer->set_timestamp(current_pts);
+    stream_parser_buffer->SetDecodeTimestamp(

[wolenetz, 2014/09/05 21:18:49]

If not set, buffer's DTS will be assumed to be PTS. See
StreamParserBuffer::GetDecodeTimestamp()
(https://code.google.com/p/chromium/codesearch#chromium/src/media/base/stream_...).
These two lines are unnecessary.

[damienv1, 2014/09/05 21:52:03]

Yes, I know. But this implicit DTS assignment is not correctly implemented in
DecodeTimestamp.
e.g.
Let's say I want to add an offset on both the pts and dts outside of this file,
I'll do:
set_timestamp(timestamp() + offset)
SetDecodeTimestamp(DecodeTimestamp() + offset)
and suddenly the DTS is applied twice the offset !

So there is sth wrong in the design of PTS/DTS inside StreamParserBuffer...

+        DecodeTimestamp::FromPresentationTime(current_pts));
     stream_parser_buffer->set_duration(frame_duration);
     emit_buffer_cb_.Run(stream_parser_buffer);
 
     // Update the PTS of the next frame.
     audio_timestamp_helper_->AddFrames(kSamplesPerAACFrame);
 
     // Skip the current frame.
     SkipAdtsFrame(adts_frame);
   }
 
@@ skipping 77 matching lines @@
     // Audio config notification.
     last_audio_decoder_config_ = audio_decoder_config;
     new_audio_config_cb_.Run(audio_decoder_config);
   }
 
   return true;
 }
 
 }  // namespace mp2t
 }  // namespace media