Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 539303002: [telemetry] Fix MSR power monitor when Python bitness doesn't match OS bitness. (Closed)

Created:
6 years, 3 months ago by dtu
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Fix MSR power monitor when Python bitness doesn't match OS bitness. The DLL must match the executable, and the kernel driver must match the OS. Confusing, I know! BUG=336558 TEST=python tools/telemetry/run_tests msr # On a machine with 32-bit Python and 64-bit Windows, in a shell with Administrator privileges. R=tonyg Committed: https://crrev.com/39a9220007d83b2f48853a500d444309c1efdfa0 Cr-Commit-Position: refs/heads/master@{#293465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M tools/telemetry/bin/win/winring0.zip.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py View 3 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dtu
6 years, 3 months ago (2014-09-04 20:44:51 UTC) #1
tonyg
lgtm
6 years, 3 months ago (2014-09-04 23:05:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/539303002/1
6 years, 3 months ago (2014-09-05 00:59:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 58905a808cde19a2446f84daaf7b796c089ac159
6 years, 3 months ago (2014-09-05 08:05:15 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39a9220007d83b2f48853a500d444309c1efdfa0
Cr-Commit-Position: refs/heads/master@{#293465}

Powered by Google App Engine
This is Rietveld 408576698