Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: ui/ios/uikit_util_unittest.mm

Issue 539253002: Add a couple UIKit util functions in src/ui/ios/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/ios/uikit_util.mm ('K') | « ui/ios/uikit_util.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ios/uikit_util_unittest.mm
diff --git a/ui/ios/uikit_util_unittest.mm b/ui/ios/uikit_util_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..3a3b9f72c737e7aefff899f33c28ee42b8e306a6
--- /dev/null
+++ b/ui/ios/uikit_util_unittest.mm
@@ -0,0 +1,51 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Foundation/Foundation.h>
+
+#include "base/basictypes.h"
+#include "testing/platform_test.h"
+#import "ui/ios/uikit_util.h"
+
+namespace {
+
+typedef PlatformTest UIKitUtilTest;
+
+TEST_F(UIKitUtilTest, AlignValueToUpperPixel) {
+ CGFloat scale = [[UIScreen mainScreen] scale];
+ // Pick a few interesting values: already aligned, aligned on retina, and
+ // some unaligned values that would round differently. Ensure that all are
+ // "integer" values within <1 of the original value in the scaled space.
+ CGFloat test_values[] = { 10.0, 55.5, 3.1, 2.9 };
+ const CGFloat kMaxAlignDelta = 0.9999;
+ size_t value_count = arraysize(test_values);
+ for (unsigned int i = 0; i < value_count; ++i) {
+ CGFloat aligned = ui::alignValueToUpperPixel(test_values[i]);
+ EXPECT_FLOAT_EQ(aligned * scale, floor(aligned * scale));
+ EXPECT_NEAR(aligned * scale, test_values[i] * scale, kMaxAlignDelta);
+ }
+}
+
+TEST_F(UIKitUtilTest, AlignSizeToUpperPixel) {
+ CGFloat scale = [[UIScreen mainScreen] scale];
+ // Pick a few interesting values: already aligned, aligned on retina, and
+ // some unaligned values that would round differently. Ensure that all are
+ // "integer" values within <1 of the original value in the scaled space.
+ CGFloat test_values[] = { 10.0, 55.5, 3.1, 2.9 };
+ const CGFloat kMaxAlignDelta = 0.9999;
+ size_t value_count = arraysize(test_values);
+ for (unsigned int i = 0; i < value_count; ++i) {
+ CGFloat width = test_values[i];
+ CGFloat height = test_values[(i + 1) % value_count];
+ CGSize alignedSize = ui::alignSizeToUpperPixel(CGSizeMake(width, height));
+ EXPECT_FLOAT_EQ(floor(alignedSize.width * scale),
+ alignedSize.width * scale);
+ EXPECT_FLOAT_EQ(floor(alignedSize.height * scale),
+ alignedSize.height * scale);
+ EXPECT_NEAR(width * scale, alignedSize.width * scale, kMaxAlignDelta);
+ EXPECT_NEAR(height * scale, alignedSize.height * scale, kMaxAlignDelta);
+ }
+}
+
+} // anonymous namespace
stuartmorgan 2014/09/04 22:16:11 Just } // namespace
lliabraa 2014/09/05 16:53:45 Done.
« ui/ios/uikit_util.mm ('K') | « ui/ios/uikit_util.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698