Add synthetic delay testing framework

base/debug/synthetic_delay.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/debug/synthetic_delay.h"
+#include "base/debug/trace_event.h"
+#include "base/memory/singleton.h"
+#include "base/synchronization/lock.h"
+#include "base/threading/platform_thread.h"
+
+namespace base {
+namespace debug {
+namespace synthetic_delay_internal {
+
+SyntheticDelay* GetOrCreateDelay(const char* name,
+                                 subtle::AtomicWord* impl_ptr) {
+  SyntheticDelay* delay_impl =
+      reinterpret_cast<SyntheticDelay*>(base::subtle::NoBarrier_Load(impl_ptr));
+  if (!delay_impl) {
+    delay_impl =
+        SyntheticDelayController::GetInstance()->GetOrCreateDelay(name);
+    subtle::NoBarrier_Store(impl_ptr,
+                            reinterpret_cast<subtle::AtomicWord>(delay_impl));
+  }
+  return delay_impl;
+}
+
+}  // namespace synthetic_delay_internal
+
+ScopedSyntheticDelay::ScopedSyntheticDelay(const char* name,
+                                           subtle::AtomicWord* impl_ptr)
+    : delay_impl_(synthetic_delay_internal::GetOrCreateDelay(name, impl_ptr)) {
+  delay_impl_->Begin();
+}
+
+ScopedSyntheticDelay::~ScopedSyntheticDelay() { delay_impl_->End(); }
+
+SyntheticDelay::SyntheticDelay() : name_(NULL) {}
+
+void SyntheticDelay::Initialize(const char* name) {
+  AutoLock lock(lock_);

[brianderson, 2013/11/05 03:12:05]

I don't think this lock is necessary, since it is only called by
SyntheticDelayController::GetOrCreateDelay, which already acquires its own
higher-level lock.

Also, the other methods of SyntheticDelay that acquire the lock will not run
concurrently with this method.

[Sami, 2013/11/22 18:29:13]

True, removed.

+  DCHECK(!thread_state_.Get());
+  name_ = name;
+}
+
+void SyntheticDelay::SetTargetDuration(base::TimeDelta target_duration) {
+  AutoLock lock(lock_);
+  target_duration_ = target_duration;
+}
+
+void SyntheticDelay::Begin() {
+  // Note that we check for a non-zero target duration without locking to keep
+  // things quick for the common case when delays are disabled. Since the delay
+  // calculation is done with a lock held, it will always be correct. The only
+  // downside of this is that we may fail to apply some delays when the target
+  // duration changes.
+  if (!target_duration_.ToInternalValue())
+    return;
+
+  // Store the start time in a thread local struct so the same delay can be
+  // applied to multiple threads simultaneously.
+  DCHECK(!thread_state_.Get());
+  scoped_ptr<ThreadState> thread_state(new ThreadState());

[brianderson, 2013/11/05 03:12:05]

Can you avoid allocating a new ThreadState for every Begin? Or is there a
concern that we might end up leaking many ThreadStates (whereas we only leak one
SyntheticDelayController singleton)?

[Sami, 2013/11/22 18:29:13]

Right, the choice is between avoiding the repeated allocations and leaking up to
#threads * kMaxSyntheticDelays structs. Since the allocations could in theory
disturb the code we're trying to test, maybe it's better just to leak the
structs.

+  thread_state->start_time = base::TimeTicks::Now();
+  thread_state_.Set(thread_state.release());
+}
+
+void SyntheticDelay::End() {
+  if (!target_duration_.ToInternalValue())
+    return;
+
+  DCHECK(thread_state_.Get());
+  scoped_ptr<ThreadState> thread_state(thread_state_.Get());
+  thread_state_.Set(NULL);
+
+  AutoLock lock(lock_);
+  base::TimeTicks now = base::TimeTicks::Now();

[brianderson, 2013/11/05 03:12:05]

Can you use HighResNow? For the scheduling tests, I think we'll care more about
precision than about overhead, especially since we will be mostly sleeping.

[Sami, 2013/11/22 18:29:13]

Great point, changed.

+  base::TimeDelta delay = target_duration_ - (now - thread_state->start_time);

[brianderson, 2013/11/05 03:12:05]

I think you should be able to AutoLock just the line above and remove the
AutoUnlock below.

[Sami, 2013/11/22 18:29:13]

Done.

+  if (delay.ToInternalValue() <= 0)
+    return;
+
+  TRACE_EVENT0("synthetic_delay", name_);
+  {
+    AutoUnlock unlock(lock_);
+    PlatformThread::Sleep(delay);
+  }
+}
+
+SyntheticDelayController* SyntheticDelayController::GetInstance() {
+  return Singleton<SyntheticDelayController,
+                   LeakySingletonTraits<SyntheticDelayController> >::get();

[brianderson, 2013/11/05 03:12:05]

What does LeakySingletonTraits do?

[Sami, 2013/11/22 18:29:13]

It's for allocating a singleton class that gets leaked at program exit. The
allocation is annotated so that there's no false positive from leak tracking
tools.

+}
+
+SyntheticDelayController::SyntheticDelayController() : delay_count_(0) {
+  for (int i = 0; i < kMaxSyntheticDelays; ++i) {
+    ANNOTATE_BENIGN_RACE(&delays_[i].target_duration_,

[brianderson, 2013/11/05 03:12:05]

What does ANNOTATE_BENIGN_RACE do?

[Sami, 2013/11/22 18:29:13]

It's another hint for dynamic code analyzers -- mostly TSAN I think. It's
basically saying that there's a known data race here, but we know it is harmless
and don't want to flag it as an error.

Actually I think I should move this closer to the actual race in
TraceEventSyntheticDelay::Begin().

+                         "synthetic delay duration");
+  }
+}
+
+SyntheticDelay* SyntheticDelayController::GetOrCreateDelay(const char* name) {
+  AutoLock lock(lock_);

[brianderson, 2013/11/05 03:12:05]

I think you can avoid taking this lock in the common case (after
initialization), by copying the for loop below and pasting it before the lock.

You'll still need to keep the copy of the for loop below that runs with the lock
acquired, to avoid racing the initialization.

You'll also need to load and increment delay_count_ atomically.

[Sami, 2013/11/22 18:29:13]

Great idea, done.

+  for (int i = 0; i < delay_count_; ++i) {
+    if (!strcmp(name, delays_[i].name_))
+      return &delays_[i];
+  }
+
+  DCHECK(delay_count_ < kMaxSyntheticDelays)
+      << "must increase kMaxSyntheticDelays";
+  if (delay_count_ >= kMaxSyntheticDelays)
+    return &dummy_delay_;
+
+  delays_[delay_count_].Initialize(name);
+  return &delays_[delay_count_++];
+}
+
+}  // namespace debug
+}  // namespace base