Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 539203002: Make index parameters in Ranges method match the type returned by size() (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make index parameters in Ranges method match the type returned by size() This changes the index parameters in start() and end() to size_t so that they match what size() returns. This fixes some compiler warnings that become errors on some of the Windows bots. BUG=408338 Committed: https://crrev.com/23f694a6bbee081b607da240018edc7898719805 Cr-Commit-Position: refs/heads/master@{#293441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M media/base/ranges.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
acolwell GONE FROM CHROMIUM
6 years, 3 months ago (2014-09-04 19:16:30 UTC) #2
scherkus (not reviewing)
lgtm
6 years, 3 months ago (2014-09-04 19:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/539203002/1
6 years, 3 months ago (2014-09-04 19:34:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10367)
6 years, 3 months ago (2014-09-05 01:52:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/539203002/1
6 years, 3 months ago (2014-09-05 01:58:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0f857b035cdbbc85a6cc712e1502ccc7ae166b39
6 years, 3 months ago (2014-09-05 04:49:08 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23f694a6bbee081b607da240018edc7898719805
Cr-Commit-Position: refs/heads/master@{#293441}

Powered by Google App Engine
This is Rietveld 408576698