Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: components/enhanced_bookmarks/bookmark_server_service.h

Issue 539173004: Bring up of the enhanced bookmarks cluster service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@intermediary2
Patch Set: battre@ feedback. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/bookmark_server_service.h
diff --git a/components/enhanced_bookmarks/bookmark_server_service.h b/components/enhanced_bookmarks/bookmark_server_service.h
index 8df0e2f878089b476d7be4361c5f50590c209952..d8cba89b66fcf39f04b0141b13e844779fe73060 100644
--- a/components/enhanced_bookmarks/bookmark_server_service.h
+++ b/components/enhanced_bookmarks/bookmark_server_service.h
@@ -64,7 +64,7 @@ class BookmarkServerService : protected net::URLFetcherDelegate,
void TriggerTokenRequest(bool cancel_previous);
// Build the query to send to the server. Returns a newly created url_fetcher.
- virtual net::URLFetcher* CreateFetcher() = 0;
+ virtual scoped_ptr<net::URLFetcher> CreateFetcher() = 0;
// Processes the response to the query. Returns true on successful parsing,
// false on failure. The implementation can assume that |should_notify| is set
@@ -86,6 +86,7 @@ class BookmarkServerService : protected net::URLFetcherDelegate,
private:
FRIEND_TEST_ALL_PREFIXES(BookmarkServerServiceTest, Cluster);
+ FRIEND_TEST_ALL_PREFIXES(BookmarkServerServiceTest, SignOut);
FRIEND_TEST_ALL_PREFIXES(BookmarkServerServiceTest,
ClearClusterMapOnRemoveAllBookmarks);
@@ -111,8 +112,6 @@ class BookmarkServerService : protected net::URLFetcherDelegate,
scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
// The fetcher used to query the server.
scoped_ptr<net::URLFetcher> url_fetcher_;
- // A map from stars.id to bookmark nodes. With no null entries.
- std::map<std::string, const BookmarkNode*> starsid_to_bookmark_;
DISALLOW_COPY_AND_ASSIGN(BookmarkServerService);
};

Powered by Google App Engine
This is Rietveld 408576698