Bring up of the enhanced bookmarks cluster service.

chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc

Index: chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc
diff --git a/chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc b/chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7933004680601c61f99540bbef2f1ba212d5545c
--- /dev/null
+++ b/chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.cc
@@ -0,0 +1,44 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h"
+
+#include "chrome/browser/sync/profile_sync_service.h"
+#include "components/bookmarks/browser/bookmark_model.h"
+
+namespace enhanced_bookmarks {
+
+ChromeBookmarkServerClusterService::ChromeBookmarkServerClusterService(
+    const std::string& application_language_code,
+    scoped_refptr<net::URLRequestContextGetter> request_context_getter,
+    ProfileOAuth2TokenService* token_service,
+    SigninManagerBase* signin_manager,
+    BookmarkModel* bookmark_model,
+    PrefService* pref_service,
+    ProfileSyncService* sync_service)
+    : BookmarkServerClusterService(application_language_code,
+                                   request_context_getter,
+                                   token_service,
+                                   signin_manager,
+                                   bookmark_model,
+                                   pref_service),
+      sync_service_(sync_service) {
+  if (sync_service_)
+    sync_service_->AddObserver(this);
+}
+
+ChromeBookmarkServerClusterService::~ChromeBookmarkServerClusterService() {
+  if (sync_service_)
+    sync_service_->RemoveObserver(this);
+}
+
+void ChromeBookmarkServerClusterService::OnStateChanged() {
+  // Do nothing.
+}
+
+void ChromeBookmarkServerClusterService::OnSyncCycleCompleted() {

[Yaron, 2014/09/05 05:18:00]

This seems a bit aggressive. I think sync cycles are too common (not to mention
that you can have multiple sync cycles in a row) to issue requests each time.
Can you not use BookmarkModelObserver instead?

Super nit: if you are keeping it, just  move the impl to |OnStateChanged| and
remove the override of this function.

[noyau (Ping after 24h), 2014/09/10 08:53:56]

This class originally used the model notification, and those happened way to
early. Doing it after a sync cycle at least guarantees that the data made it
onto the server. for that reason OnSyncCycleCompleted seems the right choice.

Also sync doesn't bracket the changes it does with ScopedGroupBookmarkAction,
this means that there is no way to know when a sync is done without using this
call (crbug/372432)

+  if (bookmark_model_->loaded())
+    TriggerTokenRequest(false);
+}
+}  // namespace enhanced_bookmarks