Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef CHROME_BROWSER_ENHANCED_BOOKMARKS_CHROME_BOOKMARK_SERVER_CLUSTER_SERVICE _H_ | |
| 6 #define CHROME_BROWSER_ENHANCED_BOOKMARKS_CHROME_BOOKMARK_SERVER_CLUSTER_SERVICE _H_ | |
| 7 | |
| 8 #include "chrome/browser/sync/profile_sync_service_observer.h" | |
| 9 #include "components/enhanced_bookmarks/bookmark_server_cluster_service.h" | |
| 10 | |
| 11 class ProfileSyncService; | |
| 12 | |
| 13 namespace enhanced_bookmarks { | |
| 14 | |
| 15 // Manages requests to the bookmark server to do just-in-time requests. | |
|
sky
2014/10/06 18:24:11
It isn't clear to me at all what any of this code
noyau (Ping after 24h)
2014/10/07 11:11:57
Updated the comment.
| |
| 16 class ChromeBookmarkServerClusterService : public BookmarkServerClusterService, | |
| 17 public ProfileSyncServiceObserver { | |
| 18 public: | |
| 19 ChromeBookmarkServerClusterService( | |
| 20 const std::string& application_language_code, | |
| 21 scoped_refptr<net::URLRequestContextGetter> request_context_getter, | |
| 22 ProfileOAuth2TokenService* token_service, | |
| 23 SigninManagerBase* signin_manager, | |
| 24 EnhancedBookmarkModel* enhanced_bookmark_model, | |
| 25 PrefService* pref_service, | |
| 26 ProfileSyncService* sync_service); | |
| 27 virtual ~ChromeBookmarkServerClusterService(); | |
| 28 | |
| 29 // ProfileSyncServiceObserver implementation. | |
| 30 virtual void OnStateChanged() OVERRIDE; | |
|
sky
2014/10/06 18:24:11
OVERRIDE->override
noyau (Ping after 24h)
2014/10/07 11:11:57
This CL actually predates that :). I fixed it in a
| |
| 31 // The stars cluster API relies on the information in chrome-sync. Sending a | |
|
sky
2014/10/06 18:24:11
Style guide says no comments like this for overrid
noyau (Ping after 24h)
2014/10/07 11:11:57
Moved.
| |
| 32 // cluster request immediately after a bookmark is changed from the bookmark | |
| 33 // observer notification will yield the wrong results. The request must be | |
| 34 // delayed until the sync cycle has completed. | |
| 35 virtual void OnSyncCycleCompleted() OVERRIDE; | |
| 36 | |
| 37 private: | |
| 38 // This class observes the sync service for changes. | |
| 39 ProfileSyncService* sync_service_; | |
| 40 | |
| 41 DISALLOW_COPY_AND_ASSIGN(ChromeBookmarkServerClusterService); | |
| 42 }; | |
| 43 | |
| 44 } // namespace enhanced_bookmarks | |
| 45 | |
| 46 #endif // CHROME_BROWSER_ENHANCED_BOOKMARKS_CHROME_BOOKMARK_SERVER_CLUSTER_SERV ICE_H_ | |
| OLD | NEW |