Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 539163004: [NaCl SDK]: use standard __BEGIN_DECLS macros in sys/select.h (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK]: use standard __BEGIN_DECLS macros in sys/select.h There is no reason for sys/select.h to depend on sdk_util headers. The __BEGIN_DECLS/__END_DECLS macros are available in all our toolchains. This was causing various problems in the naclports repo. Committed: https://crrev.com/e783a653f8005459e1bc5e26fc570ed8d205c384 Cr-Commit-Position: refs/heads/master@{#294044}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M native_client_sdk/src/libraries/third_party/newlib-extras/sys/select.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam Clegg
6 years, 3 months ago (2014-09-04 21:28:19 UTC) #2
bradn
lgtm
6 years, 3 months ago (2014-09-04 22:55:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/539163004/20001
6 years, 3 months ago (2014-09-09 23:06:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as bffa44509b38b18c2aa0c678425e84aee63cb003
6 years, 3 months ago (2014-09-10 00:10:30 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e783a653f8005459e1bc5e26fc570ed8d205c384
Cr-Commit-Position: refs/heads/master@{#294044}

Powered by Google App Engine
This is Rietveld 408576698