Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 539163003: IPv6 related histograms. (Closed)

Created:
6 years, 3 months ago by zqiu1
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IPv6 related histograms. Added histograms "Network.Shill.Cellular.IPv6ConnectivityStatus" and "Network.Shill.Wifi.IPv6ConnectivityStatus" for tracking the IPv6 connectivity status when network connection is established. This allows us to know the readiness of IPv6 connectivity in the field. Added histograms "Network.Shill.Cellular.NetworkConnectionIPType" and "Network.Shill.Wifi.NetworkConnectionIPType" for tracking the types of IP configuration use for establishing network connections. This allows us to track the usage of the newly added IPv6 connection support. BUG=chromium:207192 Committed: https://crrev.com/4c348c711e294e0a3130bf8cd2cfd11f097234d2 Cr-Commit-Position: refs/heads/master@{#293372}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 5 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
zqiu1
6 years, 3 months ago (2014-09-04 17:50:52 UTC) #2
jwd
LGTM with small nits. https://codereview.chromium.org/539163003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/539163003/diff/1/tools/metrics/histograms/histograms.xml#newcode18669 tools/metrics/histograms/histograms.xml:18669: + Chrome OS network metric ...
6 years, 3 months ago (2014-09-04 18:23:17 UTC) #3
jwd
LGTM with small nits. https://codereview.chromium.org/539163003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/539163003/diff/1/tools/metrics/histograms/histograms.xml#newcode18669 tools/metrics/histograms/histograms.xml:18669: + Chrome OS network metric ...
6 years, 3 months ago (2014-09-04 18:23:17 UTC) #4
zqiu1
Thanks. https://codereview.chromium.org/539163003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/539163003/diff/1/tools/metrics/histograms/histograms.xml#newcode18669 tools/metrics/histograms/histograms.xml:18669: + Chrome OS network metric that tracks the ...
6 years, 3 months ago (2014-09-04 18:26:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zqiu@chromium.org/539163003/20001
6 years, 3 months ago (2014-09-04 18:29:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8796)
6 years, 3 months ago (2014-09-04 22:52:44 UTC) #9
zqiu1
@isherman, please review it when you got a chance. Need your approval for commit, since ...
6 years, 3 months ago (2014-09-04 22:54:23 UTC) #10
Ilya Sherman
lgtm
6 years, 3 months ago (2014-09-04 23:04:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zqiu@chromium.org/539163003/20001
6 years, 3 months ago (2014-09-04 23:06:00 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 322056fc23cd0329f3540f62a6ce42c8017a7751
6 years, 3 months ago (2014-09-04 23:26:42 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c348c711e294e0a3130bf8cd2cfd11f097234d2
Cr-Commit-Position: refs/heads/master@{#293372}

Powered by Google App Engine
This is Rietveld 408576698