Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 539153002: Port and integrate the irregexp engine from V8 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed Ivan's comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_range_analysis.cc ('k') | runtime/vm/growable_array.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index 0501f6a944faa1ea535e2d1ad5a2cee2c6c317cb..8d1e9cebb77f1f43448799f94f27c96d54d8eb20 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -7,6 +7,7 @@
#include "vm/cha.h"
#include "vm/bit_vector.h"
#include "vm/il_printer.h"
+#include "vm/regexp_assembler.h"
namespace dart {
@@ -714,6 +715,21 @@ CompileType ParameterInstr::ComputeType() const {
}
const Function& function = graph_entry->parsed_function().function();
+ if (function.IsIrregexpFunction()) {
+ // In irregexp functions, types of input parameters are known and immutable.
+ // Set parameter types here in order to prevent unnecessary CheckClassInstr
+ // from being generated.
+ switch (index()) {
+ case RegExpMacroAssembler::kParamStringIndex:
+ return CompileType::FromCid(function.regexp_cid());
+ case RegExpMacroAssembler::kParamStartOffsetIndex:
+ return CompileType::FromCid(kSmiCid);
+ default: UNREACHABLE();
+ }
+ UNREACHABLE();
+ return CompileType::Dynamic();
+ }
+
LocalScope* scope = graph_entry->parsed_function().node_sequence()->scope();
const AbstractType& type = scope->VariableAt(index())->type();
@@ -1011,6 +1027,21 @@ CompileType LoadFieldInstr::ComputeType() const {
}
+CompileType LoadCodeUnitsInstr::ComputeType() const {
+ switch (class_id()) {
+ case kOneByteStringCid:
+ case kExternalOneByteStringCid:
+ case kTwoByteStringCid:
+ case kExternalTwoByteStringCid:
+ return can_pack_into_smi() ? CompileType::FromCid(kSmiCid)
+ : CompileType::Int();
+ default:
+ UNIMPLEMENTED();
+ return CompileType::Dynamic();
+ }
+}
+
+
CompileType BinaryInt32OpInstr::ComputeType() const {
// TODO(vegorov): range analysis information shall be used here.
return CompileType::Int();
@@ -1288,6 +1319,11 @@ CompileType MathMinMaxInstr::ComputeType() const {
}
+CompileType CaseInsensitiveCompareUC16Instr::ComputeType() const {
+ return CompileType::FromCid(kBoolCid);
+}
+
+
CompileType UnboxDoubleInstr::ComputeType() const {
return CompileType::FromCid(kDoubleCid);
}
« no previous file with comments | « runtime/vm/flow_graph_range_analysis.cc ('k') | runtime/vm/growable_array.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698