Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 539153002: Port and integrate the irregexp engine from V8 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Explicitly null IC-Data, whitespace fixes in tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index 894d0f9047c3d2f44ec07336788ce1ed2218111a..b35f91e901b97be7be17233ba0df8f01e8a347ba 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -227,7 +227,8 @@ bool FlowGraphCompiler::ForceSlowPathForStackOverflow() const {
static bool IsEmptyBlock(BlockEntryInstr* block) {
return !block->HasParallelMove() &&
block->next()->IsGoto() &&
- !block->next()->AsGoto()->HasParallelMove();
+ !block->next()->AsGoto()->HasParallelMove() &&
+ !block->IsIndirectEntry();
}
@@ -354,6 +355,7 @@ void FlowGraphCompiler::VisitBlocks() {
LoopInfoComment(assembler(), *entry, *loop_headers);
+ entry->set_offset(assembler()->CodeSize());
entry->EmitNativeCode(this);
// Compile all successors until an exit, branch, or a block entry.
for (ForwardInstructionIterator it(entry); !it.Done(); it.Advance()) {
@@ -817,6 +819,9 @@ void FlowGraphCompiler::FinalizeStackmaps(const Code& code) {
void FlowGraphCompiler::FinalizeVarDescriptors(const Code& code) {
+ // Irregexp functions do not have a node sequence.
Vyacheslav Egorov (Google) 2014/10/07 15:48:30 I wonder what happens if somebody tries to break i
jgruber1 2014/10/07 17:16:51 Done.
+ if (flow_graph().IsIrregexpFunction()) return;
+
const LocalVarDescriptors& var_descs = LocalVarDescriptors::Handle(
parsed_function_.node_sequence()->scope()->GetVarDescriptors(
parsed_function_.function()));

Powered by Google App Engine
This is Rietveld 408576698