runtime/vm/flow_graph_compiler_x64.cc - Issue 539153002: Port and integrate the irregexp engine from V8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 539153002: Port and integrate the irregexp engine from V8 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Port remaining V8 regexp tests and fix exposed bugs. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_x64.cc

diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc

index 051dc85839cd38efc691ee13e186abfab5351653..c7f65e2f0fdd3d473c4d24c95f5b239acb4eeb2e 100644

--- a/runtime/vm/flow_graph_compiler_x64.cc

+++ b/runtime/vm/flow_graph_compiler_x64.cc

@@ -1081,10 +1081,12 @@ void FlowGraphCompiler::CompileGraph() {

if (num_copied_params == 0) {

#ifdef DEBUG

ASSERT(!parsed_function().function().HasOptionalParameters());

- const bool check_arguments = !flow_graph().IsCompiledForOsr();

+ const bool check_arguments = !flow_graph().IsCompiledForOsr() &&

+ !function.IsIrregexpFunction();

Florian Schneider 2014/10/01 17:04:15 Is this necessary? IsClosureFunction implies !IsIr

jgruber1 2014/10/03 18:59:54 Done.

#else

const bool check_arguments =

- function.IsClosureFunction() && !flow_graph().IsCompiledForOsr();

+ function.IsClosureFunction() && !flow_graph().IsCompiledForOsr() &&

+ !function.IsIrregexpFunction();

#endif

if (check_arguments) {

__ Comment("Check argument count");