Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/code_generator.cc

Issue 539153002: Port and integrate the irregexp engine from V8 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/regexp.cc ('K') | « runtime/lib/string_patch.dart ('k') | runtime/vm/compiler.h » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc
index 98d46828b0a8020c2271cf9ed304663d2191dbea..d723d83d17012ce38c74d7bad138e5f3e032ed32 100644
--- a/runtime/vm/code_generator.cc
+++ b/runtime/vm/code_generator.cc
@@ -1031,6 +1031,11 @@ DEFINE_RUNTIME_ENTRY(InvokeNoSuchMethodFunction, 4) {
static bool CanOptimizeFunction(const Function& function, Isolate* isolate) {
const intptr_t kLowInvocationCount = -100000000;
+ // TODO(jgruber): Enable optimizations of irregexp functions.
+ if (function.kind() == RawFunction::kIrregexpFunction) {
+ function.set_usage_counter(kLowInvocationCount);
+ return false;
+ }
if (isolate->debugger()->IsStepping() ||
isolate->debugger()->HasBreakpoint(function)) {
// We cannot set breakpoints and single step in optimized code,
« runtime/lib/regexp.cc ('K') | « runtime/lib/string_patch.dart ('k') | runtime/vm/compiler.h » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698