Port and integrate the irregexp engine from V8

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
+#include "vm/dart_entry.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/os.h"
-#include "vm/stub_code.h"
+#include "vm/regexp_assembler.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, enable_type_checks);
 
 
 #define __ assembler->
 
 
@@ skipping 2024 matching lines @@
 void Intrinsifier::OneByteString_equality(Assembler* assembler) {
   StringEquality(assembler, kOneByteStringCid);
 }
 
 
 void Intrinsifier::TwoByteString_equality(Assembler* assembler) {
   StringEquality(assembler, kTwoByteStringCid);
 }
 
 
+void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {
+  static const intptr_t kRegExpParamOffset = + 3 * kWordSize;
+  static const intptr_t kStringParamOffset = + 2 * kWordSize;
+  // const Smi& start_index is located at   (+ 1 * kWordSize).
+
+  // Register assignments are as follows:
+  // EAX: The appropriate specialized matcher function.
+  // EBX: The regexp object.
+  // EDI: Temp, Pointer to the function's code which we then tail-call.
+
+  __ movl(EBX, Address(ESP, kRegExpParamOffset));
+  __ movl(EDI, Address(ESP, kStringParamOffset));
+
+
+  // Load the specialized function pointer into EAX. Leverage the fact the
+  // string CIDs as well as stored function pointers are in sequence.
+
+  __ LoadClassId(EDI, EDI);
+  __ SubImmediate(EDI, Immediate(kOneByteStringCid));
+  __ movl(EAX, FieldAddress(EBX, EDI, TIMES_4,
+                            JSRegExp::function_offset(kOneByteStringCid)));
+
+  // Registers have been set up for the lazy compile stub at this point.
+  // It expects the function in EAX, the argument descriptor in EDX, and
+  // IC-Data in ECX. Explicitly null out IC-Data to ensure its validity.
+
+  static const intptr_t arg_count = RegExpMacroAssembler::kParamCount;
+  __ LoadObject(EDX, Array::Handle(ArgumentsDescriptor::New(arg_count)));
+  __ movl(ECX, Immediate(reinterpret_cast<intptr_t>(Object::null())));

[Florian Schneider, 2014/10/07 12:49:36]

Alternatively, just store smi 0:

__ xorl(ECX, ECX);

(applies to the other architetures as well)

[jgruber1, 2014/10/07 15:00:25]

Done.

+
+  // Tail-call the function.
+  __ movl(EDI, FieldAddress(EAX, Function::instructions_offset()));
+  __ addl(EDI, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
+  __ jmp(EDI);
+}
+
+
 // On stack: user tag (+1), return-address (+0).
 void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) {
   Isolate* isolate = Isolate::Current();
   const Address current_tag_addr =
       Address::Absolute(reinterpret_cast<uword>(isolate) +
                         Isolate::current_tag_offset());
   const Address user_tag_addr =
       Address::Absolute(reinterpret_cast<uword>(isolate) +
                         Isolate::user_tag_offset());
   // EAX: Current user tag.
@@ skipping 28 matching lines @@
                         Isolate::current_tag_offset());
   // Set return value to Isolate::current_tag_.
   __ movl(EAX, current_tag_addr);
   __ ret();
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32