LayoutTests/media/video-currentTime-before-loadmetadata-media-fragment-uri.html - Issue 539103002: Seeking media fragment URI before loadeddata event

Side by Side Diff: LayoutTests/media/video-currentTime-before-loadmetadata-media-fragment-uri.html

Issue 539103002: Seeking media fragment URI before loadeddata event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@HAVE_NOTHING

Patch Set: Seeking media fragments if they have media controller Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/media/media-controller-media-fragment-uri.html ('K') | « LayoutTests/media/media-controller-media-fragment-uri-expected.txt ('k') | LayoutTests/media/video-currentTime-before-loadmetadata-media-fragment-uri-expected.txt » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src=media-file.js></script>	4 <script src=media-file.js></script>

5 <script src=video-test.js></script>	5 <script src=video-test.js></script>

6 <script>	6 <script>

7 function onWindowLoad(e)	7 function onWindowLoad(e)

8 {	8 {

9 video = document.getElementById('video');	9 video = document.getElementById('video');

10	10

11 video.src = findMediaFile("video", "content/test");	11 video.src = findMediaFile("video", "content/test") + "#t=2";

12 testExpected("video.currentTime", 0);	12 testExpected("video.currentTime", 0);

13 video.currentTime = 1;	13 video.currentTime = 1;

14	14

15 waitForEvent('loadedmetadata', function()	15 waitForEvent('loadedmetadata', function()

16 {	16 {

17 testExpected("video.currentTime", 1);	17 testExpected("video.currentTime", 1);

18 });	18 });

19	19

20 waitForEvent('seeked', function()	20 waitForEvent('seeked', function()

21 {	21 {

22 endTest();	22 endTest();

23 });	23 });

24 }	24 }

25	25

26 window.addEventListener('load', onWindowLoad, false);	26 window.addEventListener('load', onWindowLoad, false);

27 </script>	27 </script>

28 </head>	28 </head>

29 <body>	29 <body>

30 <video controls id="video"></video>	30 <video controls id="video"></video>

31 <p>Test currentTime values when setting while HAVE_NOTHING.</p>	31 <p>Test currentTime values when setting while HAVE_NOTHING for media fra gment URI.</p>
	philipj_slow 2014/09/10 12:25:48 Please name the two related tests similarly, maybe Please name the two related tests similarly, maybe before-loadedmetadata in both? amogh.bihani 2014/09/11 13:35:59 But the other file has nothing to do with before l Show quoted text On 2014/09/10 12:25:48, philipj wrote: > Please name the two related tests similarly, maybe before-loadedmetadata in > both? But the other file has nothing to do with before loadedmetadata... it is the event I am looking at to check the currentTime. Here we are setting currentTime before HAVE_NOTHING. philipj_slow 2014/09/11 14:38:25 Sorry, I meant video-currentTime-before-have-metad Show quoted text On 2014/09/11 13:35:59, amogh.bihani wrote: > On 2014/09/10 12:25:48, philipj wrote: > > Please name the two related tests similarly, maybe before-loadedmetadata in > > both? > > But the other file has nothing to do with before loadedmetadata... it is the > event I am looking at to check the currentTime. Here we are setting currentTime > before HAVE_NOTHING. Sorry, I meant video-currentTime-before-have-metadata.html, that showed up in the diff for patch set 3 because (I guess) it was copied from there. At least initially, those two tests were very similar. amogh.bihani 2014/09/12 11:02:23 Ah yes... this branch was made on top of that... A Show quoted text On 2014/09/11 14:38:25, philipj wrote: > On 2014/09/11 13:35:59, amogh.bihani wrote: > > On 2014/09/10 12:25:48, philipj wrote: > > > Please name the two related tests similarly, maybe before-loadedmetadata in > > > both? > > > > But the other file has nothing to do with before loadedmetadata... it is the > > event I am looking at to check the currentTime. Here we are setting > currentTime > > before HAVE_NOTHING. > > Sorry, I meant video-currentTime-before-have-metadata.html, that showed up in > the diff for patch set 3 because (I guess) it was copied from there. At least > initially, those two tests were very similar. Ah yes... this branch was made on top of that... Although after that patch merged I rebased it on top of master, the base URL is still showing <path>/blink.git@HAVE_NOTHING. (HAVE_NOTHING) was name of my local branch for that CL.
32 <br/>	32 <br/>

33 </body>	33 </body>

34 </html>	34 </html>

OLD	NEW