LayoutTests/media/media-controller-media-fragment-uri.html - Issue 539103002: Seeking media fragment URI before loadeddata event

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/media-controller-media-fragment-uri.html

Issue 539103002: Seeking media fragment URI before loadeddata event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@HAVE_NOTHING

Patch Set: Seeking media fragments if they have media controller Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/media/media-controller-media-fragment-uri-expected.txt » ('j') | LayoutTests/media/video-currentTime-before-loadmetadata-media-fragment-uri.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src=media-file.js></script>

	5 <script src=video-test.js></script>

	6 <script>

	7 var video2;
	philipj_slow 2014/09/10 12:25:48 Don't need these two vars, you need them to end up Don't need these two vars, you need them to end up on window anyway. amogh.bihani 2014/09/11 13:35:59 Done. Show quoted text On 2014/09/10 12:25:48, philipj wrote: > Don't need these two vars, you need them to end up on window anyway. Done.
	8 var controller;

	9 function onWindowLoad()

	10 {

	11 video = document.getElementById('video1');
	philipj_slow 2014/09/10 12:25:48 I'd get rid of the ids and just use videos = getEl I'd get rid of the ids and just use videos = getElementsByTagName('video') amogh.bihani 2014/09/11 13:35:59 Done. Show quoted text On 2014/09/10 12:25:48, philipj wrote: > I'd get rid of the ids and just use videos = getElementsByTagName('video') Done.
	12 video2 = document.getElementById('video2');

	13 run('controller = video.controller');
	philipj_slow 2014/09/10 12:25:48 why run? why run? amogh.bihani 2014/09/11 13:35:59 Dont know... it was getting timeout without this : Show quoted text On 2014/09/10 12:25:48, philipj wrote: > why run? Dont know... it was getting timeout without this :/
	14

	15 var src = findMediaFile("video", "content/test");

	16 video.src = src + "#t=2";

	17 video2.src = src;

	18 testExpected("video.currentTime", 0);

	19 testExpected("video2.currentTime", 0);

	20

	21 controller.addEventListener('loadedmetadata', function()

	22 {

	23 testExpected("video.currentTime", 2);

	24 testExpected("video2.currentTime", 2);

	25 testExpected("controller.currentTime", 2);

	26 });

	27

	28 waitForEvent('seeked', function()
	philipj_slow 2014/09/10 12:25:48 waitForEventAndEnd("seeked") waitForEventAndEnd("seeked") amogh.bihani 2014/09/11 13:35:59 Done. Show quoted text On 2014/09/10 12:25:48, philipj wrote: > waitForEventAndEnd("seeked") Done.
	29 {

	30 endTest();

	31 });

	32 }

	33

	34 window.addEventListener('load', onWindowLoad, false);
	philipj_slow 2014/09/10 12:25:48 Many tests have a runTest function, I think that's Many tests have a runTest function, I think that's nicer than onWindowLoad. Note that you could also just put the script after the videos and not wait for the load event at all, if you want. amogh.bihani 2014/09/11 13:35:59 Done. Show quoted text On 2014/09/10 12:25:48, philipj wrote: > Many tests have a runTest function, I think that's nicer than onWindowLoad. Note > that you could also just put the script after the videos and not wait for the > load event at all, if you want. Done.
	35 </script>

	36 </head>

	37 <body>

	38 <p>Test currentTime of media controller when one of the element has init ial start time greater than 0.</p>

	39 <video controls id="video1" mediaGroup="group"></video>

	40 <video controls id="video2" mediaGroup="group"></video>

	41 <br/>

	42 </body>

	43 </html>

OLD	NEW