LayoutTests/media/media-controller-media-fragment-uri.html - Issue 539103002: Seeking media fragment URI before loadeddata event

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/media-controller-media-fragment-uri.html

Issue 539103002: Seeking media fragment URI before loadeddata event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@HAVE_NOTHING

Patch Set: Addressing comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head></head>
	philipj_slow 2014/09/11 14:38:26 You don't need an empty <head>. If you like, don't You don't need an empty <head>. If you like, don't need <html> or <body> either, see e.g. video-buffered.html amogh.bihani 2014/09/12 11:02:23 Ummm... I was advised by srirama.m@ to add the <ht Show quoted text On 2014/09/11 14:38:26, philipj wrote: > You don't need an empty <head>. If you like, don't need <html> or <body> either, > see e.g. video-buffered.html Ummm... I was advised by srirama.m@ to add the <html> tag because he was onced asked in one of his CLs philipj_slow 2014/09/16 12:27:15 In the style of an existing test is OK. I happen t Show quoted text On 2014/09/12 11:02:23, amogh.bihani wrote: > On 2014/09/11 14:38:26, philipj wrote: > > You don't need an empty <head>. If you like, don't need <html> or <body> > either, > > see e.g. video-buffered.html > > Ummm... I was advised by srirama.m@ to add the <html> tag because he was onced > asked in one of his CLs In the style of an existing test is OK. I happen to prefer minimalist tests using testharness.js, but am not going to enforce it.
	4 <body>

	5 <video controls mediaGroup="group"></video>

	6 <video controls mediaGroup="group"></video>

	7 <script src=media-file.js></script>

	8 <script src=video-test.js></script>

	9 <script>

	10 videos = document.getElementsByTagName('video');

	11 video = videos[0];

	12 video2 = videos[1];

	13 controller = video.controller;

	14

	15 var src = findMediaFile("video", "content/test");

	16 video.src = src + "#t=2";

	17 video2.src = src;

	18 testExpected("video.currentTime", 0);

	19 testExpected("video2.currentTime", 0);

	20

	21 controller.addEventListener('loadedmetadata', function()

	22 {

	23 testExpected("video.currentTime", 2);

	24 testExpected("video2.currentTime", 2);

	25 testExpected("controller.currentTime", 2);

	26 });

	27

	28 waitForEvent('seeked');
	philipj_slow 2014/09/11 14:38:26 This test is timing out, should use waitForEventAn This test is timing out, should use waitForEventAndEnd. amogh.bihani 2014/09/12 11:02:23 Done. Show quoted text On 2014/09/11 14:38:26, philipj wrote: > This test is timing out, should use waitForEventAndEnd. Done.
	29 </script>

	30 <p>Test currentTime of media controller when one of the element has init ial start time greater than 0.</p>
	philipj_slow 2014/09/11 14:38:28 Please move this description to the top, or <title Please move this description to the top, or <title> since it doesn't really matter if it's in the expectations file. amogh.bihani 2014/09/12 11:02:23 Done. Show quoted text On 2014/09/11 14:38:28, philipj wrote: > Please move this description to the top, or <title> since it doesn't really > matter if it's in the expectations file. Done.
	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/media-controller-media-fragment-uri-expected.txt » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')