Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1752)

Issue 538983002: Merge 180450 "Avoid GCing an aborting and stopped FileReader." (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
Reviewers:
sof
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Project:
blink
Visibility:
Public.

Description

Merge 180450 "Avoid GCing an aborting and stopped FileReader." > Avoid GCing an aborting and stopped FileReader. > > If a FileReader is abort()ed, a task is scheduled to perform the actual > abort operation. Should the containing Document's ActiveDOMObjects be > stopped before that task gets to run, the FileReader would already > advance to a DONE state and be at risk from being GCed before the abort > task gets to run. If so, it would then access a dead object. > > The provided test elicits an assert that shows up the problem, but > doesn't trigger the GC and subsequent access of the dead object. > > R=kouhei@chromium.org, tzik@chromium.org > BUG=404513 > > Review URL: https://codereview.chromium.org/478263002 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --3 lines) Patch
A + LayoutTests/fast/files/file-reader-abort-gc-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/files/file-reader-abort-gc-iframe-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/files/resources/file-reader-abort-gc-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sof
6 years, 3 months ago (2014-09-04 09:50:22 UTC) #1
sof
6 years, 3 months ago (2014-09-04 09:51:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r181365.

Powered by Google App Engine
This is Rietveld 408576698