Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: Source/bindings/tests/results/V8TestCallbackInterface.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/callback_interface.cpp ('k') | Source/core/inspector/InspectorOverlay.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestCallbackInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestCallbackInterface.cpp b/Source/bindings/tests/results/V8TestCallbackInterface.cpp
index d16d7890664b27c36659c4aa1dcedfc6d802fe38..c2bfc73cc6fca1d3c19cee74c83b1a8ae6657d48 100644
--- a/Source/bindings/tests/results/V8TestCallbackInterface.cpp
+++ b/Source/bindings/tests/results/V8TestCallbackInterface.cpp
@@ -34,7 +34,7 @@ void V8TestCallbackInterface::voidMethod()
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -48,7 +48,7 @@ bool V8TestCallbackInterface::booleanMethod()
if (!canInvokeCallback())
return true;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return true;
ScriptState::Scope scope(m_scriptState.get());
@@ -65,7 +65,7 @@ void V8TestCallbackInterface::voidMethodBooleanArg(bool boolArg)
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -85,7 +85,7 @@ void V8TestCallbackInterface::voidMethodSequenceArg(const Vector<RefPtr<TestInte
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -105,7 +105,7 @@ void V8TestCallbackInterface::voidMethodFloatArg(float floatArg)
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -125,7 +125,7 @@ void V8TestCallbackInterface::voidMethodTestInterfaceEmptyArg(TestInterfaceEmpty
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -145,7 +145,7 @@ void V8TestCallbackInterface::voidMethodTestInterfaceEmptyStringArg(TestInterfac
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -171,7 +171,7 @@ void V8TestCallbackInterface::callbackWithThisValueVoidMethodStringArg(ScriptVal
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -197,7 +197,7 @@ void V8TestCallbackInterface::voidMethodWillBeGarbageCollectedSequenceArg(const
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
@@ -217,7 +217,7 @@ void V8TestCallbackInterface::voidMethodWillBeGarbageCollectedArrayArg(const Wil
if (!canInvokeCallback())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValid())
return;
ScriptState::Scope scope(m_scriptState.get());
« no previous file with comments | « Source/bindings/templates/callback_interface.cpp ('k') | Source/core/inspector/InspectorOverlay.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698