Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/WindowProxy.cpp ('k') | Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 242bcccca3cad89a1beecc2b90207cd919e11c19..a1b92f224754722963d739922bc533813edf61ea 100644

--- a/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -334,7 +334,7 @@ v8::Handle<v8::Value> DialogHandler::returnValue() const

{

if (!m_scriptStateForDialogFrame)

return v8Undefined();

- ASSERT(!m_scriptStateForDialogFrame->contextIsEmpty());

+ ASSERT(!m_scriptStateForDialogFrame->contextIsValid());

v8::Isolate* isolate = m_scriptStateForDialogFrame->isolate();

v8::EscapableHandleScope handleScope(isolate);

« no previous file with comments | « Source/bindings/core/v8/WindowProxy.cpp ('k') | Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp » ('j') | no next file with comments »