Source/bindings/core/v8/V8MutationCallback.cpp - Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8MutationCallback.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/V8EventListenerList.cpp ('k') | Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/V8MutationCallback.cpp

diff --git a/Source/bindings/core/v8/V8MutationCallback.cpp b/Source/bindings/core/v8/V8MutationCallback.cpp

index 312fa03fe5a16b85c1a9ecab13ca9e5d06b94f55..8dfd8ee01e233f56f40ff6b791c3e436e32460e9 100644

--- a/Source/bindings/core/v8/V8MutationCallback.cpp

+++ b/Source/bindings/core/v8/V8MutationCallback.cpp

@@ -52,7 +52,7 @@ void V8MutationCallback::call(const WillBeHeapVector<RefPtrWillBeMember<Mutation

v8::Isolate* isolate = m_scriptState->isolate();

- if (m_scriptState->contextIsEmpty())

+ if (m_scriptState->contextIsValid())

return;

ScriptState::Scope scope(m_scriptState.get());

« no previous file with comments | « Source/bindings/core/v8/V8EventListenerList.cpp ('k') | Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »