Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: Source/bindings/core/v8/ScriptValue.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptState.cpp ('k') | Source/bindings/core/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptValue.cpp
diff --git a/Source/bindings/core/v8/ScriptValue.cpp b/Source/bindings/core/v8/ScriptValue.cpp
index 7167aebbbfe5790394453ff708878ec69cc5bdab..5b7a362ce41c97e9952fceecdb756f13e0f14e18 100644
--- a/Source/bindings/core/v8/ScriptValue.cpp
+++ b/Source/bindings/core/v8/ScriptValue.cpp
@@ -76,7 +76,7 @@ bool ScriptValue::toString(String& result) const
PassRefPtr<JSONValue> ScriptValue::toJSONValue(ScriptState* scriptState) const
{
- ASSERT(!scriptState->contextIsEmpty());
+ ASSERT(!scriptState->contextIsValid());
ScriptState::Scope scope(scriptState);
return v8ToJSONValue(scriptState->isolate(), v8Value(), JSONValue::maxDepth);
}
« no previous file with comments | « Source/bindings/core/v8/ScriptState.cpp ('k') | Source/bindings/core/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698