Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index 242bcccca3cad89a1beecc2b90207cd919e11c19..21aaf9ca78f82806e7c851e7d4f615a25a32ed12 100644
--- a/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -334,7 +334,7 @@ v8::Handle<v8::Value> DialogHandler::returnValue() const
{
if (!m_scriptStateForDialogFrame)
return v8Undefined();
- ASSERT(!m_scriptStateForDialogFrame->contextIsEmpty());
+ ASSERT(!m_scriptStateForDialogFrame->contextIsValue());
v8::Isolate* isolate = m_scriptStateForDialogFrame->isolate();
v8::EscapableHandleScope handleScope(isolate);

Powered by Google App Engine
This is Rietveld 408576698