Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: Source/bindings/core/v8/ScheduledAction.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptController.cpp » ('j') | Source/bindings/core/v8/ScriptState.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScheduledAction.cpp
diff --git a/Source/bindings/core/v8/ScheduledAction.cpp b/Source/bindings/core/v8/ScheduledAction.cpp
index b0315ae806413692cd7657f28bab68feba0427c7..28bfe26e508f267a36168bae57fc6ef0d160388d 100644
--- a/Source/bindings/core/v8/ScheduledAction.cpp
+++ b/Source/bindings/core/v8/ScheduledAction.cpp
@@ -83,7 +83,7 @@ void ScheduledAction::execute(ExecutionContext* context)
void ScheduledAction::execute(LocalFrame* frame)
{
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValue())
return;
TRACE_EVENT0("v8", "ScheduledAction::execute");
@@ -102,7 +102,7 @@ void ScheduledAction::execute(LocalFrame* frame)
void ScheduledAction::execute(WorkerGlobalScope* worker)
{
ASSERT(worker->thread()->isCurrentThread());
- ASSERT(!m_scriptState->contextIsEmpty());
+ ASSERT(!m_scriptState->contextIsValue());
if (!m_function.isEmpty()) {
ScriptState::Scope scope(m_scriptState.get());
Vector<v8::Handle<v8::Value> > info;
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptController.cpp » ('j') | Source/bindings/core/v8/ScriptState.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698