[fsp] Wire FSP to chrome.fileBrowserPrivate.getEntryProperties().

[fsp] Wire FSP to chrome.fileBrowserPrivate.getEntryProperties().

This patch wires FSP extra metadata fields (especially thumbnails) to the
chrome.fileBrowserPrivate.getEntryProperties() method used by Files app.

As a result, Files app will be able to get extra metadata fields for provided
file systems.

Note, that Files app does not invoke getEntryProperties() for entries on
provided file systems yet. It will be done in a separate patch.

TEST=browser_tests: *FileSystemProvider*Thumbnail*
BUG=407954, 408017
Committed: https://crrev.com/8de02bf644695a94dd422c2f8deaccb687dd7824
Cr-Commit-Position: refs/heads/master@{#294075}

[mtomasz, 2014-09-04 03:17:19]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org, yoshiki@chromium.org

[mtomasz, 2014-09-04 03:17:30]

@yoshiki: PTAL at C++.
@hirono: PTAL at JS.

Thanks.

[hirono, 2014-09-04 03:52:01]

lgtm for *.js

[yoshiki, 2014-09-04 05:29:21]

lgtm with nits

https://codereview.chromium.org/538873002/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
(right):

https://codereview.chromium.org/538873002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:366: const
ResultCallback& callback) {
nit: Please DCHECK if the current thread is the UI. We need to make it sure that
both new and delete are done in the same thread.

https://codereview.chromium.org/538873002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:429: delete
this;
Asynchronous delete should be safer.

eg. BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this) 


Because in case of StartProcess -> CompleteGetEntryProperties callpath, the
'parser' variable in StartProcess() method, which uses 'file_system_url_'
property, is free'd after 'this' is deleted. This is not safe.

[mtomasz, 2014-09-04 06:22:08]

https://codereview.chromium.org/538873002/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
(right):

https://codereview.chromium.org/538873002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:366: const
ResultCallback& callback) {
On 2014/09/04 05:29:21, yoshiki wrote:
> nit: Please DCHECK if the current thread is the UI. We need to make it sure
that
> both new and delete are done in the same thread.

Done.

https://codereview.chromium.org/538873002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:429: delete
this;
On 2014/09/04 05:29:21, yoshiki wrote:
> Asynchronous delete should be safer.
> 
> eg. BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this) 
> 
> 
> Because in case of StartProcess -> CompleteGetEntryProperties callpath, the
> 'parser' variable in StartProcess() method, which uses 'file_system_url_'
> property, is free'd after 'this' is deleted. This is not safe.

Good idea. Done.

[mtomasz, 2014-09-04 09:23:59]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-04 09:25:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/538873002/20001

[commit-bot: I haz the power, 2014-09-04 09:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 09:35:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2014-09-05 05:37:43]

mtomasz@chromium.org changed reviewers:
+ benwells@chromium.org

[mtomasz, 2014-09-05 05:37:55]

@benwells: PTAL at IDL.

[benwells, 2014-09-09 17:55:48]

idl lgtm. rubber stamp lgtm for the custom bindings js.

[mtomasz, 2014-09-10 00:52:19]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-10 01:09:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/538873002/20001

[commit-bot: I haz the power, 2014-09-10 02:04:01]

Committed patchset #2 (id:20001) as c1f685dbcbdf6954a775abc53c3b78b32b626bad

[commit-bot: I haz the power, 2014-09-10 03:57:43]

Patchset 2 (id:??) landed as
https://crrev.com/8de02bf644695a94dd422c2f8deaccb687dd7824
Cr-Commit-Position: refs/heads/master@{#294075}